From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Davide Libenzi <davidel@xmailserver.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ingo Molnar <mingo@elte.hu>,
Laurent Riffard <laurent.riffard@free.fr>,
Pavel Emelyanov <xemul@openvz.org>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] don't panic if /sbin/init exits or killed
Date: Sun, 16 Mar 2008 18:54:53 +0300 [thread overview]
Message-ID: <20080316155453.GA20845@tv-sign.ru> (raw)
If the buggy init exits, the kernel panics. I see no point for this. It is very
possible that the system is still usable enough, at least to read the logs and
prepare the bug report.
Change exit_child_reaper() to do BUG() instead of panic().
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 25/kernel/exit.c~4_EXIT_DONT_PANIC 2008-03-16 16:49:30.000000000 +0300
+++ 25/kernel/exit.c 2008-03-16 16:49:35.000000000 +0300
@@ -861,8 +861,10 @@ static inline void exit_child_reaper(str
if (likely(tsk->group_leader != task_child_reaper(tsk)))
return;
- if (tsk->nsproxy->pid_ns == &init_pid_ns)
- panic("Attempted to kill init!");
+ if (unlikely(tsk->nsproxy->pid_ns == &init_pid_ns)) {
+ printk(KERN_EMERG "Kernel panic - init is killed!\n");
+ BUG();
+ }
/*
* @tsk is the last thread in the 'cgroup-init' and is exiting.
next reply other threads:[~2008-03-16 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-16 15:54 Oleg Nesterov [this message]
2008-03-16 22:19 ` Roland McGrath
2008-03-16 22:54 ` Krzysztof Halasa
2008-03-16 23:03 ` Oleg Nesterov
2008-03-16 22:55 ` Alan Cox
2008-03-16 23:32 ` Roland McGrath
2008-03-16 23:49 ` Oleg Nesterov
2008-03-16 23:59 ` Roland McGrath
2008-03-17 0:05 ` Oleg Nesterov
[not found] ` <1205850955.6466.61.camel@moss-spartans.epoch.ncsc.mil>
2008-03-18 15:41 ` Oleg Nesterov
2008-03-29 5:47 ` H. Peter Anvin
2008-03-29 10:51 ` Oleg Nesterov
[not found] <a83rs-N7-9@gated-at.bofh.it>
[not found] ` <a89wR-8k4-3@gated-at.bofh.it>
[not found] ` <a8a9t-1pV-21@gated-at.bofh.it>
[not found] ` <a8aCw-2hv-31@gated-at.bofh.it>
2008-03-18 17:41 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080316155453.GA20845@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=ebiederm@xmission.com \
--cc=laurent.riffard@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®