From: Oleg Nesterov <oleg@tv-sign.ru>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Davide Libenzi <davidel@xmailserver.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ingo Molnar <mingo@elte.hu>,
Laurent Riffard <laurent.riffard@free.fr>,
Pavel Emelyanov <xemul@openvz.org>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [PATCH 4/5] don't panic if /sbin/init exits or killed
Date: Sat, 29 Mar 2008 13:51:12 +0300 [thread overview]
Message-ID: <20080329105112.GC359@tv-sign.ru> (raw)
In-Reply-To: <47EDD80C.6030507@zytor.com>
On 03/28, H. Peter Anvin wrote:
>
> Oleg Nesterov wrote:
> >If the buggy init exits, the kernel panics. I see no point for this. It is
> >very
> >possible that the system is still usable enough, at least to read the logs
> >and
> >prepare the bug report.
> >
> >Change exit_child_reaper() to do BUG() instead of panic().
> >
> >Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
>
> This would be highly undesirable in a production system, since it would
> leave the machine an unusable zombie. In a production system, the panic
> can be made to reboot the system, bringing it back online.
I can't agree. Following this logic, we should always use panic() instead
of BUG().
I think the system should try to use any chance to survive, and we have
panic_on_oops.
That said, Stephen has a good reason to nack this patch. But still I hope
it is possible to find a simple solution. Not that I think this is really
important, but this panic() is silly, imho.
Oleg.
next prev parent reply other threads:[~2008-03-29 10:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-16 15:54 Oleg Nesterov
2008-03-16 22:19 ` Roland McGrath
2008-03-16 22:54 ` Krzysztof Halasa
2008-03-16 23:03 ` Oleg Nesterov
2008-03-16 22:55 ` Alan Cox
2008-03-16 23:32 ` Roland McGrath
2008-03-16 23:49 ` Oleg Nesterov
2008-03-16 23:59 ` Roland McGrath
2008-03-17 0:05 ` Oleg Nesterov
[not found] ` <1205850955.6466.61.camel@moss-spartans.epoch.ncsc.mil>
2008-03-18 15:41 ` Oleg Nesterov
2008-03-29 5:47 ` H. Peter Anvin
2008-03-29 10:51 ` Oleg Nesterov [this message]
[not found] <a83rs-N7-9@gated-at.bofh.it>
[not found] ` <a89wR-8k4-3@gated-at.bofh.it>
[not found] ` <a8a9t-1pV-21@gated-at.bofh.it>
[not found] ` <a8aCw-2hv-31@gated-at.bofh.it>
2008-03-18 17:41 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080329105112.GC359@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=laurent.riffard@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®