From: Ravikiran G Thirumalai <kiran@scalex86.org>
To: Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Glauber de Oliveira Costa <gcosta@redhat.com>,
Andi Kleen <ak@suse.de>,
shai@scalex86.org
Subject: [patch 4/4] x86: apic_is_clustered_box to indicate unsynched TSC's on multiboard vSMP systems
Date: Thu, 20 Mar 2008 00:45:08 -0700 [thread overview]
Message-ID: <20080320074508.GE9414@localdomain> (raw)
In-Reply-To: <20080320073740.GA9414@localdomain>
Indicate TSCs are unreliable as time sources if the platform is
a multi chassi ScaleMP vSMPowered machine.
Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Index: linux.git.trees/arch/x86/kernel/apic_64.c
===================================================================
--- linux.git.trees.orig/arch/x86/kernel/apic_64.c 2008-03-19 20:42:28.187659497 -0700
+++ linux.git.trees/arch/x86/kernel/apic_64.c 2008-03-19 21:24:17.705515003 -0700
@@ -1208,7 +1208,7 @@ __cpuinit int apic_is_clustered_box(void
* will be [4, 0x23] or [8, 0x27] could be thought to
* vsmp box still need checking...
*/
- if (!is_vsmp_box() && (boot_cpu_data.x86_vendor == X86_VENDOR_AMD))
+ if ((boot_cpu_data.x86_vendor == X86_VENDOR_AMD) && !is_vsmp_box())
return 0;
bios_cpu_apicid = x86_bios_cpu_apicid_early_ptr;
@@ -1248,6 +1248,12 @@ __cpuinit int apic_is_clustered_box(void
++zeros;
}
+ /* ScaleMP vSMPowered boxes have one cluster per board and TSCs are
+ * not guaranteed to be synced between boards
+ */
+ if (is_vsmp_box() && clusters > 1)
+ return 1;
+
/*
* If clusters > 2, then should be multi-chassis.
* May have to revisit this when multi-core + hyperthreaded CPUs come
next prev parent reply other threads:[~2008-03-20 7:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 7:37 [patch 0/4] x86: vSMP updates Ravikiran G Thirumalai
2008-03-20 7:39 ` [patch 1/4] x86: vSMP: Fix is_vsmp_box() Ravikiran G Thirumalai
2008-03-20 7:44 ` Yinghai Lu
2008-03-20 18:40 ` Ravikiran G Thirumalai
2008-03-21 9:11 ` Ingo Molnar
2008-03-21 9:17 ` Yinghai Lu
2008-03-21 17:59 ` Ravikiran G Thirumalai
2008-03-20 7:41 ` [patch 2/4] x86: Fix build breakage when PCI is define and PARAVIRT is not Ravikiran G Thirumalai
2008-03-21 4:30 ` Jeremy Fitzhardinge
2008-03-21 6:28 ` Yinghai Lu
2008-03-21 18:54 ` Ravikiran G Thirumalai
2008-03-22 2:19 ` Jeremy Fitzhardinge
2008-03-20 7:43 ` [patch 3/4] x86: vSMP: Use pvops only if platform has the capability to support it Ravikiran G Thirumalai
2008-03-20 7:45 ` Ravikiran G Thirumalai [this message]
2008-03-20 7:53 ` [patch 4/4] x86: apic_is_clustered_box to indicate unsynched TSC's on multiboard vSMP systems Yinghai Lu
2008-03-20 19:02 ` Ravikiran G Thirumalai
2008-03-21 9:15 ` Ingo Molnar
2008-03-21 18:52 ` Ravikiran G Thirumalai
2008-03-21 18:58 ` Ingo Molnar
2008-03-22 18:59 ` Ravikiran G Thirumalai
2008-03-22 20:02 ` Ingo Molnar
2008-03-24 21:48 ` Ravikiran G Thirumalai
2008-03-25 15:50 ` Ingo Molnar
2008-03-21 8:54 ` [patch 0/4] x86: vSMP updates Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080320074508.GE9414@localdomain \
--to=kiran@scalex86.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome