mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86: change pci_direct_conf1 back not static
@ 2008-03-18 18:02 Yinghai Lu
  2008-03-21 11:26 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Yinghai Lu @ 2008-03-18 18:02 UTC (permalink / raw)
  To: Ingo Molnar, Glauber Costa; +Cc: Linux Kernel ML

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pci_direct_conf1.patch --]
[-- Type: text/x-patch; name=pci_direct_conf1.patch, Size: 1137 bytes --]

[PATCH] x86: change pci_direct_conf1 back not static

Glauber Costa <glommer@gmail.com> pointed out

    commit 513f484dfe5cbb53e73ef1729703e7030e799487

    x86 pci: remove checking type for mmconfig probe v2

broke the VISW.

remove the static in declaration.

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>

diff --git a/arch/x86/pci/direct.c b/arch/x86/pci/direct.c
index 739ce26..21d1e0e 100644
--- a/arch/x86/pci/direct.c
+++ b/arch/x86/pci/direct.c
@@ -76,7 +76,7 @@ static int pci_conf1_write(unsigned int seg, unsigned int bus,
 
 #undef PCI_CONF1_ADDRESS
 
-static struct pci_raw_ops pci_direct_conf1 = {
+struct pci_raw_ops pci_direct_conf1 = {
 	.read =		pci_conf1_read,
 	.write =	pci_conf1_write,
 };
diff --git a/arch/x86/pci/pci.h b/arch/x86/pci/pci.h
index d345661..c9fb637 100644
--- a/arch/x86/pci/pci.h
+++ b/arch/x86/pci/pci.h
@@ -95,6 +95,8 @@ struct pci_raw_ops {
 extern struct pci_raw_ops *raw_pci_ops;
 extern struct pci_raw_ops *raw_pci_ext_ops;
 
+extern struct pci_raw_ops pci_direct_conf1;
+
 extern int pci_direct_probe(void);
 extern void pci_direct_init(int type);
 extern void pci_pcbios_init(void);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86: change pci_direct_conf1 back not static
  2008-03-18 18:02 [PATCH] x86: change pci_direct_conf1 back not static Yinghai Lu
@ 2008-03-21 11:26 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-03-21 11:26 UTC (permalink / raw)
  To: Yinghai Lu; +Cc: Glauber Costa, Linux Kernel ML


* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> Glauber Costa <glommer@gmail.com> pointed out
> 
>     commit 513f484dfe5cbb53e73ef1729703e7030e799487
> 
>     x86 pci: remove checking type for mmconfig probe v2
> 
> broke the VISW.
> 
> remove the static in declaration.

thanks, applied.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-21 11:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-18 18:02 [PATCH] x86: change pci_direct_conf1 back not static Yinghai Lu
2008-03-21 11:26 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®