* [PATCH 3/7] net/ipv6/ndisc.c: remove unused variable
@ 2008-03-15 16:03 Julia Lawall
2008-03-23 1:04 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2008-03-15 16:03 UTC (permalink / raw)
To: davem, pekkas, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The variable hlen is initialized but never used otherwise.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
identifier i;
constant C;
@@
(
extern T i;
|
- T i;
<+... when != i
- i = C;
...+>
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
net/ipv6/ndisc.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
--- a/net/ipv6/ndisc.c 2008-03-12 14:13:15.000000000 +0100
+++ b/net/ipv6/ndisc.c 2008-03-15 07:30:11.000000000 +0100
@@ -1420,7 +1420,6 @@ void ndisc_send_redirect(struct sk_buff
u8 *opt;
int rd_len;
int err;
- int hlen;
u8 ha_buf[MAX_ADDR_LEN], *ha = NULL;
dev = skb->dev;
@@ -1491,7 +1490,6 @@ void ndisc_send_redirect(struct sk_buff
return;
}
- hlen = 0;
skb_reserve(buff, LL_RESERVED_SPACE(dev));
ip6_nd_hdr(sk, buff, dev, &saddr_buf, &ipv6_hdr(skb)->saddr,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/7] net/ipv6/ndisc.c: remove unused variable
2008-03-15 16:03 [PATCH 3/7] net/ipv6/ndisc.c: remove unused variable Julia Lawall
@ 2008-03-23 1:04 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-03-23 1:04 UTC (permalink / raw)
To: julia; +Cc: pekkas, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Sat, 15 Mar 2008 17:03:20 +0100 (CET)
> The variable hlen is initialized but never used otherwise.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-23 1:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-15 16:03 [PATCH 3/7] net/ipv6/ndisc.c: remove unused variable Julia Lawall
2008-03-23 1:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®