mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/7] net/9p/trans_fd.c: remove unused variable
@ 2008-03-15 16:02 Julia Lawall
  2008-03-23  1:05 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2008-03-15 16:02 UTC (permalink / raw)
  To: ericvh, rminnich, lucho, v9fs-developer, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

The variable cb is initialized but never used otherwise.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  <+... when != i
- i = C;
  ...+>
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
---
 net/9p/trans_fd.c |    2 --
 1 file changed, 2 deletions(-)

diff -u -p a/net/9p/trans_fd.c b/net/9p/trans_fd.c
--- a/net/9p/trans_fd.c 2008-03-12 14:13:15.000000000 +0100
+++ b/net/9p/trans_fd.c 2008-03-15 07:27:23.000000000 +0100
@@ -861,7 +861,6 @@ static void p9_mux_free_request(struct p
 
 static void p9_mux_flush_cb(struct p9_req *freq, void *a)
 {
-	p9_conn_req_callback cb;
 	int tag;
 	struct p9_conn *m;
 	struct p9_req *req, *rreq, *rptr;
@@ -872,7 +871,6 @@ static void p9_mux_flush_cb(struct p9_re
 		freq->tcall->params.tflush.oldtag);
 
 	spin_lock(&m->lock);
-	cb = NULL;
 	tag = freq->tcall->params.tflush.oldtag;
 	req = NULL;
 	list_for_each_entry_safe(rreq, rptr, &m->req_list, req_list) {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/7] net/9p/trans_fd.c: remove unused variable
  2008-03-15 16:02 [PATCH 2/7] net/9p/trans_fd.c: remove unused variable Julia Lawall
@ 2008-03-23  1:05 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-03-23  1:05 UTC (permalink / raw)
  To: julia
  Cc: ericvh, rminnich, lucho, v9fs-developer, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>
Date: Sat, 15 Mar 2008 17:02:58 +0100 (CET)

> The variable cb is initialized but never used otherwise.
> 
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
 ...
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-23  1:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-15 16:02 [PATCH 2/7] net/9p/trans_fd.c: remove unused variable Julia Lawall
2008-03-23  1:05 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®