* [PATCH] pids: sys_getpgid: use rcu_read_lock() instead of tasklist_lock
@ 2008-03-23 17:51 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2008-03-23 17:51 UTC (permalink / raw)
To: Andrew Morton; +Cc: Eric W. Biederman, Pavel Emelyanov, linux-kernel
Convert sys_getpgid() to use rcu_read_lock() instead of tasklist_lock, make
sure we also check the result of task_pgrp_vnr().
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 25/kernel/sys.c~2_GETPGID 2008-03-23 19:25:36.000000000 +0300
+++ 25/kernel/sys.c 2008-03-23 20:39:03.000000000 +0300
@@ -988,19 +988,19 @@ asmlinkage long sys_getpgid(pid_t pid)
if (!pid)
return task_pgrp_vnr(current);
else {
- int retval;
+ int retval = 0;
struct task_struct *p;
- read_lock(&tasklist_lock);
+ rcu_read_lock();
p = find_task_by_vpid(pid);
- retval = -ESRCH;
if (p) {
retval = security_task_getpgid(p);
if (!retval)
retval = task_pgrp_vnr(p);
}
- read_unlock(&tasklist_lock);
- return retval;
+ rcu_read_unlock();
+
+ return retval ?: -ESRCH;
}
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-03-23 17:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-23 17:51 [PATCH] pids: sys_getpgid: use rcu_read_lock() instead of tasklist_lock Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®