From: David Miller <davem@davemloft.net>
To: m.kozlowski@tuxland.pl
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: sparc64 BUG: using smp_processor_id() in preemptible
Date: Wed, 26 Mar 2008 04:25:16 -0700 (PDT) [thread overview]
Message-ID: <20080326.042516.261621639.davem@davemloft.net> (raw)
In-Reply-To: <20080326.041626.224135350.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 26 Mar 2008 04:16:26 -0700 (PDT)
> From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> Date: Wed, 26 Mar 2008 11:42:07 +0100
>
> > I see lots of these messages on my ultra 60 box.
>
> This is a sparc64 bug.
And this patch should fix it:
commit 69072f6e8e4bd4799d2a54e4ff8771d0657512c1
Author: David S. Miller <davem@davemloft.net>
Date: Wed Mar 26 04:25:00 2008 -0700
[SPARC64]: Fix __get_cpu_var in preemption-enabled area.
Reported by Mariusz Kozlowski.
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/arch/sparc64/mm/tlb.c b/arch/sparc64/mm/tlb.c
index 3f10fc9..a0f000b 100644
--- a/arch/sparc64/mm/tlb.c
+++ b/arch/sparc64/mm/tlb.c
@@ -23,10 +23,11 @@ DEFINE_PER_CPU(struct mmu_gather, mmu_gathers) = { 0, };
void flush_tlb_pending(void)
{
- struct mmu_gather *mp = &__get_cpu_var(mmu_gathers);
+ struct mmu_gather *mp;
preempt_disable();
+ mp = &__get_cpu_var(mmu_gathers);
if (mp->tlb_nr) {
flush_tsb_user(mp);
next prev parent reply other threads:[~2008-03-26 11:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 2:07 Linux 2.6.25-rc7 Linus Torvalds
2008-03-26 10:42 ` sparc64 BUG: using smp_processor_id() in preemptible Mariusz Kozlowski
2008-03-26 11:16 ` David Miller
2008-03-26 11:25 ` David Miller [this message]
2008-03-26 11:46 ` Mariusz Kozlowski
2008-03-26 11:51 ` David Miller
2008-03-26 12:10 ` Mariusz Kozlowski
2008-03-27 3:25 ` Andrew Morton
2008-03-27 6:33 ` David Miller
2008-03-26 12:02 ` Linux 2.6.25-rc7 sparc64 loops forever on cat /proc/<pid>/pagemap Mariusz Kozlowski
2008-03-27 0:35 ` David Miller
2008-03-28 11:33 ` Mariusz Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326.042516.261621639.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®