From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: m.kozlowski@tuxland.pl, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: sparc64 BUG: using smp_processor_id() in preemptible
Date: Wed, 26 Mar 2008 23:33:54 -0700 (PDT) [thread overview]
Message-ID: <20080326.233354.102892522.davem@davemloft.net> (raw)
In-Reply-To: <20080326202502.f06938bd.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Wed, 26 Mar 2008 20:25:02 -0700
> On Wed, 26 Mar 2008 04:25:16 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>
> > preempt_disable();
> >
> > + mp = &__get_cpu_var(mmu_gathers);
>
> that's an open-coded get_cpu_var().
>
> fwiw. Which isn't much, IMO. Sometimes it's nice to see things open-coded.
Good point, I might restructure that to use {get,put}_cpu_var().
next prev parent reply other threads:[~2008-03-27 6:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 2:07 Linux 2.6.25-rc7 Linus Torvalds
2008-03-26 10:42 ` sparc64 BUG: using smp_processor_id() in preemptible Mariusz Kozlowski
2008-03-26 11:16 ` David Miller
2008-03-26 11:25 ` David Miller
2008-03-26 11:46 ` Mariusz Kozlowski
2008-03-26 11:51 ` David Miller
2008-03-26 12:10 ` Mariusz Kozlowski
2008-03-27 3:25 ` Andrew Morton
2008-03-27 6:33 ` David Miller [this message]
2008-03-26 12:02 ` Linux 2.6.25-rc7 sparc64 loops forever on cat /proc/<pid>/pagemap Mariusz Kozlowski
2008-03-27 0:35 ` David Miller
2008-03-28 11:33 ` Mariusz Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326.233354.102892522.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®