From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org, akpm@linux-foundation.org,
trond.myklebust@fys.uio.no, chuck.lever@oracle.com
Cc: nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, selinux@tycho.nsa.gov,
linux-security-module@vger.kernel.org, dhowells@redhat.com
Subject: [PATCH 40/45] NFS: Add read context retention for FS-Cache to call back with [ver #35]
Date: Fri, 28 Mar 2008 14:33:36 +0000 [thread overview]
Message-ID: <20080328143336.3483.65183.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <20080328143010.3483.99079.stgit@warthog.procyon.org.uk>
Add read context retention so that FS-Cache can call back into NFS when a read
operation on the cache fails EIO rather than reading data. This permits NFS to
then fetch the data from the server instead using the appropriate security
context.
Signed-off-by: David Howells <dhowells@redhat.com>
---
fs/nfs/fscache-index.c | 26 ++++++++++++++++++++++++++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/fs/nfs/fscache-index.c b/fs/nfs/fscache-index.c
index 1522496..54b8d9e 100644
--- a/fs/nfs/fscache-index.c
+++ b/fs/nfs/fscache-index.c
@@ -287,6 +287,30 @@ static void nfs_fscache_inode_now_uncached(void *cookie_netfs_data)
}
/*
+ * Get an extra reference on a read context.
+ * - This function can be absent if the completion function doesn't require a
+ * context.
+ * - The read context is passed back to NFS in the event that a data read on the
+ * cache fails with EIO - in which case the server must be contacted to
+ * retrieve the data, which requires the read context for security.
+ */
+static void nfs_fh_get_context(void *cookie_netfs_data, void *context)
+{
+ get_nfs_open_context(context);
+}
+
+/*
+ * Release an extra reference on a read context.
+ * - This function can be absent if the completion function doesn't require a
+ * context.
+ */
+static void nfs_fh_put_context(void *cookie_netfs_data, void *context)
+{
+ if (context)
+ put_nfs_open_context(context);
+}
+
+/*
* Define the inode object for FS-Cache. This is used to describe an inode
* object to fscache_acquire_cookie(). It is keyed by the NFS file handle for
* an inode.
@@ -303,4 +327,6 @@ const struct fscache_cookie_def nfs_fscache_inode_object_def = {
.get_aux = nfs_fscache_inode_get_aux,
.check_aux = nfs_fscache_inode_check_aux,
.now_uncached = nfs_fscache_inode_now_uncached,
+ .get_context = nfs_fh_get_context,
+ .put_context = nfs_fh_put_context,
};
next prev parent reply other threads:[~2008-03-28 14:43 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 14:30 [PATCH 00/45] Permit filesystem local caching " David Howells
2008-03-28 14:30 ` [PATCH 01/45] KEYS: Increase the payload size when instantiating a key " David Howells
2008-03-28 14:30 ` [PATCH 02/45] KEYS: Check starting keyring as part of search " David Howells
2008-03-28 14:30 ` [PATCH 03/45] KEYS: Allow the callout data to be passed as a blob rather than a string " David Howells
2008-03-28 14:30 ` [PATCH 04/45] KEYS: Allow clients to set key perms in key_create_or_update() " David Howells
2008-03-28 14:30 ` [PATCH 05/45] KEYS: Don't generate user and user session keyrings unless they're accessed " David Howells
2008-03-28 14:30 ` [PATCH 06/45] KEYS: Make the keyring quotas controllable through /proc/sys " David Howells
2008-04-01 15:29 ` Berthold Cogel
2008-03-28 14:30 ` [PATCH 07/45] KEYS: Make key_serial() a function if CONFIG_KEYS=y " David Howells
2008-03-28 14:30 ` [PATCH 08/45] KEYS: Add keyctl function to get a security label " David Howells
2008-03-28 14:30 ` [PATCH 09/45] Security: Change current->fs[ug]id to current_fs[ug]id() " David Howells
2008-03-28 14:31 ` [PATCH 10/45] Security: Separate task security context from task_struct " David Howells
2008-03-28 14:31 ` [PATCH 11/45] Security: De-embed task security record from task and use refcounting " David Howells
2008-03-28 14:31 ` [PATCH 12/45] Security: Add a kernel_service object class to SELinux " David Howells
2008-03-28 14:31 ` [PATCH 13/45] Security: Allow kernel services to override LSM settings for task actions " David Howells
2008-03-28 14:31 ` [PATCH 14/45] Security: Make NFSD work with detached security " David Howells
2008-03-28 14:31 ` [PATCH 15/45] FS-Cache: Release page->private after failed readahead " David Howells
2008-03-28 14:31 ` [PATCH 16/45] FS-Cache: Recruit a couple of page flags for cache management " David Howells
2008-03-28 14:31 ` [PATCH 17/45] FS-Cache: Provide an add_wait_queue_tail() function " David Howells
2008-03-28 14:31 ` [PATCH 18/45] FS-Cache: Generic filesystem caching facility " David Howells
2008-03-28 14:31 ` [PATCH 19/45] Add missing consts to xattr function arguments " David Howells
2008-03-28 14:31 ` [PATCH 20/45] CacheFiles: Add missing copy_page export for ia64 " David Howells
2008-03-28 14:31 ` [PATCH 21/45] CacheFiles: Be consistent about the use of mapping vs file->f_mapping in Ext3 " David Howells
2008-03-28 14:32 ` [PATCH 22/45] CacheFiles: Add a hook to write a single page of data to an inode " David Howells
2008-03-28 14:32 ` [PATCH 23/45] CacheFiles: Permit the page lock state to be monitored " David Howells
2008-03-28 14:32 ` [PATCH 24/45] CacheFiles: Export things for CacheFiles " David Howells
2008-03-28 14:32 ` [PATCH 25/45] CacheFiles: A cache that backs onto a mounted filesystem " David Howells
2008-03-28 14:32 ` [PATCH 26/45] AFS: Add a MAINTAINERS record for AFS " David Howells
2008-03-28 14:32 ` [PATCH 27/45] AFS: prevent double cell registration " David Howells
2008-03-28 14:32 ` [PATCH 28/45] FS-Cache: Make kAFS use FS-Cache " David Howells
2008-03-28 14:32 ` [PATCH 29/45] NFS: Add comment banners to some NFS functions " David Howells
2008-03-28 14:32 ` [PATCH 30/45] NFS: Add FS-Cache option bit and debug bit " David Howells
2008-03-28 14:32 ` [PATCH 31/45] NFS: Permit local filesystem caching to be enabled for NFS " David Howells
2008-03-28 14:32 ` [PATCH 32/45] NFS: Register NFS for caching and retrieve the top-level index " David Howells
2008-03-28 14:33 ` [PATCH 33/45] NFS: Define and create server-level objects " David Howells
2008-03-28 14:33 ` [PATCH 34/45] NFS: Define and create superblock-level " David Howells
2008-03-28 14:33 ` [PATCH 35/45] NFS: Define and create inode-level cache " David Howells
2008-03-28 14:33 ` [PATCH 36/45] NFS: Use local disk inode cache " David Howells
2008-03-28 14:33 ` [PATCH 37/45] NFS: Invalidate FsCache page flags when cache removed " David Howells
2008-03-28 14:33 ` [PATCH 38/45] NFS: Add some new I/O counters for FS-Cache doing things for NFS " David Howells
2008-03-28 14:33 ` [PATCH 39/45] NFS: FS-Cache page management " David Howells
2008-03-28 14:33 ` David Howells [this message]
2008-03-28 14:33 ` [PATCH 41/45] NFS: nfs_readpage_async() needs to be accessible as a fallback for local caching " David Howells
2008-03-28 14:33 ` [PATCH 42/45] NFS: Read pages from FS-Cache into an NFS inode " David Howells
2008-03-28 14:33 ` [PATCH 43/45] NFS: Store pages from an NFS inode into a local cache " David Howells
2008-03-28 14:33 ` [PATCH 44/45] NFS: Display local caching state " David Howells
2008-03-28 14:34 ` [PATCH 45/45] NFS: Add mount options to enable local caching on NFS " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328143336.3483.65183.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chuck.lever@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=selinux@tycho.nsa.gov \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®