* [2.6 patch] mmc/core/sdio_ops.c should #include "sdio_ops.h"
@ 2008-04-13 18:15 Adrian Bunk
2008-04-16 17:34 ` Pierre Ossman
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-04-13 18:15 UTC (permalink / raw)
To: drzeus-mmc; +Cc: linux-kernel
Every file should include the headers containing the externs for its
global functions.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
74cc02b17c51b27632b49e7092ba4f79ff6f2f26 diff --git a/drivers/mmc/core/sdio_ops.c b/drivers/mmc/core/sdio_ops.c
index e1fca58..c8fa095 100644
--- a/drivers/mmc/core/sdio_ops.c
+++ b/drivers/mmc/core/sdio_ops.c
@@ -17,6 +17,7 @@
#include <linux/mmc/sdio.h>
#include "core.h"
+#include "sdio_ops.h"
int mmc_send_io_op_cond(struct mmc_host *host, u32 ocr, u32 *rocr)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] mmc/core/sdio_ops.c should #include "sdio_ops.h"
2008-04-13 18:15 [2.6 patch] mmc/core/sdio_ops.c should #include "sdio_ops.h" Adrian Bunk
@ 2008-04-16 17:34 ` Pierre Ossman
0 siblings, 0 replies; 2+ messages in thread
From: Pierre Ossman @ 2008-04-16 17:34 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Sun, 13 Apr 2008 21:15:52 +0300
Adrian Bunk <bunk@kernel.org> wrote:
> Every file should include the headers containing the externs for its
> global functions.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
I suppose that's a good idea. Applied.
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-16 17:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-13 18:15 [2.6 patch] mmc/core/sdio_ops.c should #include "sdio_ops.h" Adrian Bunk
2008-04-16 17:34 ` Pierre Ossman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®