From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: David Fries <david@fries.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read_id multiple short read bug
Date: Mon, 14 Apr 2008 15:40:55 +0400 [thread overview]
Message-ID: <20080414114055.GA13385@2ka.mipt.ru> (raw)
In-Reply-To: <20080413231537.GF15213@spacedout.fries.net>
Hi David.
On Sun, Apr 13, 2008 at 06:15:37PM -0500, David Fries (david@fries.net) wrote:
> This is more to point out the bug in w1_slave_read_id, the next patch
> rewrites the routine.
>
> w1.c 1.15
...
> w1.c 1.16
That is what I talked about. I agree with your analysis of the problem
and I agree with fixes. But I do not agree with how you created them:
why do we ever neen 1.15 version, since immediately after that we have
1.16 which completely rewrite what was done in previous one?
This applies to the whole patchset: there are essentially several bug
fixes and several features, so separate them into several patches, which
do not collide with each other in the above way.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-04-14 11:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 12:23 [PATCH 0/35] W1: w1 core deadlock and oops fixes, ds2490 updates David Fries
2008-03-30 11:27 ` Evgeniy Polyakov
2008-04-13 22:56 ` David Fries
2008-04-13 23:14 ` [PATCH 7/33 replaces 7/35] W1: feature, enable hardware strong pullup David Fries
2008-04-13 23:14 ` [PATCH 8/33 replaces 8/35 and 9/35] W1: feature, w1_therm.c use strong pullup and documentation David Fries
2008-04-13 23:14 ` [PATCH 9/33 replaces 10/35] W1: be able to manually add and remove slaves David Fries
2008-04-13 23:15 ` [PATCH 11/33 replaces 12/35] W1: new module parameter search_count David Fries
2008-04-13 23:15 ` [PATCH 12/33 replaces 13/35] W1: Document add, remove, search_count, and pullup David Fries
2008-04-13 23:15 ` [PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read_id multiple short read bug David Fries
2008-04-14 11:40 ` Evgeniy Polyakov [this message]
2008-04-14 22:22 ` David Fries
2008-04-13 23:15 ` [PATCH 32/33 replaces 34/35] Documentation/w1/masters/ds2490 update David Fries
2008-04-14 12:30 ` [PATCH 0/35] W1: w1 core deadlock and oops fixes, ds2490 updates Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414114055.GA13385@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=david@fries.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome