From: Jeff Dike <jdike@addtoit.com>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [Patch] uml: compile error fix
Date: Mon, 14 Apr 2008 11:03:58 -0400 [thread overview]
Message-ID: <20080414150358.GD7186@c2.user-mode-linux.org> (raw)
In-Reply-To: <20080412.174733.133433510.xiyou.wangcong@gmail.com>
On Sat, Apr 12, 2008 at 05:47:33PM +0800, WANG Cong wrote:
>
> This patch fixes this error:
>
> CC arch/um/kernel/smp.o
> In file included from /home/wangcong/projects/linux-2.6/arch/um/kernel/smp.c:9:
> include2/asm/tlb.h: In function ‘tlb_remove_page’:
> include2/asm/tlb.h:101: error: implicit declaration of function ‘page_cache_release’
> make[2]: *** [arch/um/kernel/smp.o] Error 1
> make[1]: *** [arch/um/kernel] Error 2
> make: *** [sub-make] Error 2
>
> And since including <linux/pagemap.h> in <linux/swap.h> will break sparc,
> we add this #include in uml's own header.
Sigh, ACK.
I took a stab at fixing this problem for real a while ago by
untangling the headers involved, but failed.
Jeff
--
Work email - jdike at linux dot intel dot com
prev parent reply other threads:[~2008-04-14 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 9:47 WANG Cong
2008-04-14 15:03 ` Jeff Dike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414150358.GD7186@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome