* [Patch] uml: compile error fix
@ 2008-04-12 9:47 WANG Cong
2008-04-14 15:03 ` Jeff Dike
0 siblings, 1 reply; 2+ messages in thread
From: WANG Cong @ 2008-04-12 9:47 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, jdike, user-mode-linux-devel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=gb2312, Size: 1059 bytes --]
This patch fixes this error:
CC arch/um/kernel/smp.o
In file included from /home/wangcong/projects/linux-2.6/arch/um/kernel/smp.c:9:
include2/asm/tlb.h: In function ¡®tlb_remove_page¡¯:
include2/asm/tlb.h:101: error: implicit declaration of function ¡®page_cache_release¡¯
make[2]: *** [arch/um/kernel/smp.o] Error 1
make[1]: *** [arch/um/kernel] Error 2
make: *** [sub-make] Error 2
And since including <linux/pagemap.h> in <linux/swap.h> will break sparc,
we add this #include in uml's own header.
Cc: Jeff Dike <jdike@addtoit.com>
Signed-off-by: WANG Cong <wangcong@zeuux.org>
---
diff --git a/include/asm-um/tlb.h b/include/asm-um/tlb.h
index 39fc475..5240fa1 100644
--- a/include/asm-um/tlb.h
+++ b/include/asm-um/tlb.h
@@ -1,6 +1,7 @@
#ifndef __UM_TLB_H
#define __UM_TLB_H
+#include <linux/pagemap.h>
#include <linux/swap.h>
#include <asm/percpu.h>
#include <asm/pgalloc.h>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch] uml: compile error fix
2008-04-12 9:47 [Patch] uml: compile error fix WANG Cong
@ 2008-04-14 15:03 ` Jeff Dike
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Dike @ 2008-04-14 15:03 UTC (permalink / raw)
To: WANG Cong; +Cc: linux-kernel, akpm, user-mode-linux-devel
On Sat, Apr 12, 2008 at 05:47:33PM +0800, WANG Cong wrote:
>
> This patch fixes this error:
>
> CC arch/um/kernel/smp.o
> In file included from /home/wangcong/projects/linux-2.6/arch/um/kernel/smp.c:9:
> include2/asm/tlb.h: In function ‘tlb_remove_page’:
> include2/asm/tlb.h:101: error: implicit declaration of function ‘page_cache_release’
> make[2]: *** [arch/um/kernel/smp.o] Error 1
> make[1]: *** [arch/um/kernel] Error 2
> make: *** [sub-make] Error 2
>
> And since including <linux/pagemap.h> in <linux/swap.h> will break sparc,
> we add this #include in uml's own header.
Sigh, ACK.
I took a stab at fixing this problem for real a while ago by
untangling the headers involved, but failed.
Jeff
--
Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-14 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-12 9:47 [Patch] uml: compile error fix WANG Cong
2008-04-14 15:03 ` Jeff Dike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome