[PATCH] smb.h: uses struct timespec but didn't include linux/time.h

[PATCH] smb.h: uses struct timespec but didn't include linux/time.h

[Ilpo Järvinen]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 435 bytes --]


Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
 include/linux/smb.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/smb.h b/include/linux/smb.h
index f098dff..caa43b2 100644
--- a/include/linux/smb.h
+++ b/include/linux/smb.h
@@ -11,6 +11,7 @@
 
 #include <linux/types.h>
 #include <linux/magic.h>
+#include <linux/time.h>
 
 enum smb_protocol { 
 	SMB_PROTOCOL_NONE, 
-- 
1.5.2.2

Re: [PATCH] smb.h: uses struct timespec but didn't include linux/time.h

[Andrew Morton]

On Tue, 15 Apr 2008 12:04:04 +0300 (EEST) "Ilpo J__rvinen" <ilpo.jarvinen@helsinki.fi> wrote:

> 
> Signed-off-by: Ilpo J__rvinen <ilpo.jarvinen@helsinki.fi>
> ---
>  include/linux/smb.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/smb.h b/include/linux/smb.h
> index f098dff..caa43b2 100644
> --- a/include/linux/smb.h
> +++ b/include/linux/smb.h
> @@ -11,6 +11,7 @@
>  
>  #include <linux/types.h>
>  #include <linux/magic.h>
> +#include <linux/time.h>
>  
>  enum smb_protocol { 
>  	SMB_PROTOCOL_NONE, 

Did this actually cause a compilation error?

Re: [PATCH] smb.h: uses struct timespec but didn't include linux/time.h

[Ilpo Järvinen]

On Tue, 15 Apr 2008, Andrew Morton wrote:

> On Tue, 15 Apr 2008 12:04:04 +0300 (EEST) "Ilpo J__rvinen" <ilpo.jarvinen@helsinki.fi> wrote:
> 
> > 
> > Signed-off-by: Ilpo J__rvinen <ilpo.jarvinen@helsinki.fi>
> > ---
> >  include/linux/smb.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/smb.h b/include/linux/smb.h
> > index f098dff..caa43b2 100644
> > --- a/include/linux/smb.h
> > +++ b/include/linux/smb.h
> > @@ -11,6 +11,7 @@
> >  
> >  #include <linux/types.h>
> >  #include <linux/magic.h>
> > +#include <linux/time.h>
> >  
> >  enum smb_protocol { 
> >  	SMB_PROTOCOL_NONE, 
> 
> Did this actually cause a compilation error?

No and yes, none I know of in mainline but with my uninlining tool, if 
that counts :-), it did until I work-around the number of compilation 
failures I got if I just include a single header file to a uninlined.c by 
taking an existing compilation unit's list of headers (and hoping for the 
best), which worked most of time (this case include). ...I'm not sure 
should they all be fixed or not (not to speak of how). Finding most of 
them seems relatively easy to automate by include alone + compile.


-- 
 i.

Re: [PATCH] smb.h: uses struct timespec but didn't include linux/time.h

[Adrian Bunk]

On Tue, Apr 15, 2008 at 02:10:57AM -0700, Andrew Morton wrote:
> On Tue, 15 Apr 2008 12:04:04 +0300 (EEST) "Ilpo J__rvinen" <ilpo.jarvinen@helsinki.fi> wrote:
> 
> > 
> > Signed-off-by: Ilpo J__rvinen <ilpo.jarvinen@helsinki.fi>
> > ---
> >  include/linux/smb.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/smb.h b/include/linux/smb.h
> > index f098dff..caa43b2 100644
> > --- a/include/linux/smb.h
> > +++ b/include/linux/smb.h
> > @@ -11,6 +11,7 @@
> >  
> >  #include <linux/types.h>
> >  #include <linux/magic.h>
> > +#include <linux/time.h>
> >  
> >  enum smb_protocol { 
> >  	SMB_PROTOCOL_NONE, 
> 
> Did this actually cause a compilation error?

Even if it doesn't at the moment it should be fixed - these kind
of issues are why often adding or removing an #include in a header 
suddenly breaks some configuration on some other architecture.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] smb.h: uses struct timespec but didn't include linux/time.h

[Ilpo Järvinen]

On Tue, 15 Apr 2008, Adrian Bunk wrote:

> On Tue, Apr 15, 2008 at 02:10:57AM -0700, Andrew Morton wrote:
> > On Tue, 15 Apr 2008 12:04:04 +0300 (EEST) "Ilpo J__rvinen" <ilpo.jarvinen@helsinki.fi> wrote:
> > >  
> > > +#include <linux/time.h>
> > 
> > Did this actually cause a compilation error?
> 
> Even if it doesn't at the moment it should be fixed - these kind
> of issues are why often adding or removing an #include in a header 
> suddenly breaks some configuration on some other architecture.

...I suppose point of Andrew's enquiry was more about determining how 
soon it should be scheduled for inclusion rather than its usefulness.

-- 
 i.