From: Pavel Machek <pavel@ucw.cz>
To: SL Baur <steve@xemacs.org>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: gart: factor out common code
Date: Wed, 16 Apr 2008 10:14:18 +0200 [thread overview]
Message-ID: <20080416081418.GA5105@elf.ucw.cz> (raw)
In-Reply-To: <ed10ee420804151625i1e30abb7r98ddda53ec6e8da6@mail.gmail.com>
On Tue 2008-04-15 16:25:29, SL Baur wrote:
> On 4/15/08, Pavel Machek <pavel@ucw.cz> wrote:
> > Cleanup gart handling on amd64 a bit: move common code into
> > enable_gart_translation , and use symbolic register names where
> > appropriate.
> >
> > Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> Which source tree is this patch against? I'm looking at Linus
> latest and I don't see the AMD64_* constants defined in the
> same place.
x86 tree, hopefully.
> Other reviewer comments:
> The casting between struct pci_dev * and u64 is kind of ugly,
> I presume the reason for the narrowing casts in the block of
> code you moved is documented somewhere.
Where am I doing that?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-04-16 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 10:43 Pavel Machek
2008-04-15 23:25 ` SL Baur
2008-04-16 8:14 ` Pavel Machek [this message]
2008-04-17 2:55 ` SL Baur
2008-04-17 6:29 ` Andi Kleen
2008-04-17 7:34 ` SL Baur
2008-04-16 13:08 ` Ingo Molnar
2008-04-16 22:50 ` Yinghai Lu
2008-04-16 22:56 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416081418.GA5105@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steve@xemacs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome