* [PATCH] x86_64 vDSO: compile with -g
@ 2008-04-14 19:19 Roland McGrath
2008-04-14 20:59 ` Sam Ravnborg
2008-04-16 12:59 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Roland McGrath @ 2008-04-14 19:19 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner; +Cc: Andrew Morton, Linus Torvalds, linux-kernel
The 64-bit vDSO's sources are compiled with -g0 for no good reason.
Using -g when enabled lets their separate debug files be used at
runtime via build ID matching, same as we can see 32-bit vDSO's
assembly sources.
Signed-off-by: Roland McGrath <roland@redhat.com>
---
arch/x86/vdso/Makefile | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
index 0a8f474..e5745a6 100644
--- a/arch/x86/vdso/Makefile
+++ b/arch/x86/vdso/Makefile
@@ -37,7 +37,8 @@ $(obj)/%.so: OBJCOPYFLAGS := -S
$(obj)/%.so: $(obj)/%.so.dbg FORCE
$(call if_changed,objcopy)
-CFL := $(PROFILING) -mcmodel=small -fPIC -g0 -O2 -fasynchronous-unwind-tables -m64
+CFL := $(PROFILING) -mcmodel=small -fPIC -O2 -fasynchronous-unwind-tables -m64 \
+ $(filter -g%,$(KBUILD_CFLAGS))
$(vobjs): KBUILD_CFLAGS = $(CFL)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86_64 vDSO: compile with -g
2008-04-14 19:19 [PATCH] x86_64 vDSO: compile with -g Roland McGrath
@ 2008-04-14 20:59 ` Sam Ravnborg
2008-04-16 12:59 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2008-04-14 20:59 UTC (permalink / raw)
To: Roland McGrath
Cc: Ingo Molnar, Thomas Gleixner, Andrew Morton, Linus Torvalds,
linux-kernel
On Mon, Apr 14, 2008 at 12:19:30PM -0700, Roland McGrath wrote:
> The 64-bit vDSO's sources are compiled with -g0 for no good reason.
> Using -g when enabled lets their separate debug files be used at
> runtime via build ID matching, same as we can see 32-bit vDSO's
> assembly sources.
>
> Signed-off-by: Roland McGrath <roland@redhat.com>
Looks good.
Acked-by: Sam Ravnborg <sam@ravnborg.org>
[I have not tested it]
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86_64 vDSO: compile with -g
2008-04-14 19:19 [PATCH] x86_64 vDSO: compile with -g Roland McGrath
2008-04-14 20:59 ` Sam Ravnborg
@ 2008-04-16 12:59 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-04-16 12:59 UTC (permalink / raw)
To: Roland McGrath
Cc: Thomas Gleixner, Andrew Morton, Linus Torvalds, linux-kernel
* Roland McGrath <roland@redhat.com> wrote:
> The 64-bit vDSO's sources are compiled with -g0 for no good reason.
> Using -g when enabled lets their separate debug files be used at
> runtime via build ID matching, same as we can see 32-bit vDSO's
> assembly sources.
>
> Signed-off-by: Roland McGrath <roland@redhat.com>
thanks Roland, applied.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-16 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-14 19:19 [PATCH] x86_64 vDSO: compile with -g Roland McGrath
2008-04-14 20:59 ` Sam Ravnborg
2008-04-16 12:59 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®