[2.6 patch] make dm_{,un}register_dirty_log_type() static

[2.6 patch] make dm_{,un}register_dirty_log_type() static

[Adrian Bunk]

This patch makes the needlessly global dm_{,un}register_dirty_log_type() 
static.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 drivers/md/dm-log.c |    6 ++----
 drivers/md/dm-log.h |    3 ---
 2 files changed, 2 insertions(+), 7 deletions(-)

5d0ca5f52a1c756246411406890c10b2d5cdd081 diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c
index 2a74b21..0d65cc7 100644
--- a/drivers/md/dm-log.c
+++ b/drivers/md/dm-log.c
@@ -17,7 +17,7 @@
 static LIST_HEAD(_log_types);
 static DEFINE_SPINLOCK(_lock);
 
-int dm_register_dirty_log_type(struct dirty_log_type *type)
+static int dm_register_dirty_log_type(struct dirty_log_type *type)
 {
 	spin_lock(&_lock);
 	type->use_count = 0;
@@ -27,7 +27,7 @@ int dm_register_dirty_log_type(struct dirty_log_type *type)
 	return 0;
 }
 
-int dm_unregister_dirty_log_type(struct dirty_log_type *type)
+static int dm_unregister_dirty_log_type(struct dirty_log_type *type)
 {
 	spin_lock(&_lock);
 
@@ -782,7 +782,5 @@ void dm_dirty_log_exit(void)
 	dm_unregister_dirty_log_type(&_core_type);
 }
 
-EXPORT_SYMBOL(dm_register_dirty_log_type);
-EXPORT_SYMBOL(dm_unregister_dirty_log_type);
 EXPORT_SYMBOL(dm_create_dirty_log);
 EXPORT_SYMBOL(dm_destroy_dirty_log);
diff --git a/drivers/md/dm-log.h b/drivers/md/dm-log.h
index 3fae87e..c45fc25 100644
--- a/drivers/md/dm-log.h
+++ b/drivers/md/dm-log.h
@@ -110,9 +110,6 @@ struct dirty_log_type {
 		      char *result, unsigned int maxlen);
 };
 
-int dm_register_dirty_log_type(struct dirty_log_type *type);
-int dm_unregister_dirty_log_type(struct dirty_log_type *type);
-
 
 /*
  * Make sure you use these two functions, rather than calling

Re: [dm-devel] [2.6 patch] make dm_{, un}register_dirty_log_type() static

[Alasdair G Kergon]

On Mon, Mar 31, 2008 at 02:28:24AM +0300, Adrian Bunk wrote:
> This patch makes the needlessly global dm_{,un}register_dirty_log_type() 
> static.
 
(Patch superceded by other interface changes.)

Actively used in an area of out-of-tree development which should move in-tree
when it's ready.

Alasdair
-- 
agk@redhat.com