[2.6 patch] make mmc_wait_for_app_cmd() static

[2.6 patch] make mmc_wait_for_app_cmd() static

[Adrian Bunk]

This patch makes the needlessly global mmc_wait_for_app_cmd() static.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 drivers/mmc/core/sd_ops.c |    6 ++----
 include/linux/mmc/core.h  |    2 --
 2 files changed, 2 insertions(+), 6 deletions(-)

91b65cb8cda7a2197ebb5c4e4669933a09547057 diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c
index 0d96080..4831a3d 100644
--- a/drivers/mmc/core/sd_ops.c
+++ b/drivers/mmc/core/sd_ops.c
@@ -62,8 +62,8 @@ static int mmc_app_cmd(struct mmc_host *host, struct mmc_card *card)
  *	that occurred while the command was executing.  Do not attempt to
  *	parse the response.
  */
-int mmc_wait_for_app_cmd(struct mmc_host *host, struct mmc_card *card,
-	struct mmc_command *cmd, int retries)
+static int mmc_wait_for_app_cmd(struct mmc_host *host, struct mmc_card *card,
+				struct mmc_command *cmd, int retries)
 {
 	struct mmc_request mrq;
 
@@ -115,8 +115,6 @@ int mmc_wait_for_app_cmd(struct mmc_host *host, struct mmc_card *card,
 	return err;
 }
 
-EXPORT_SYMBOL(mmc_wait_for_app_cmd);
-
 int mmc_app_set_bus_width(struct mmc_card *card, int width)
 {
 	int err;
diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
index d0c3abe..c8d9a60 100644
--- a/include/linux/mmc/core.h
+++ b/include/linux/mmc/core.h
@@ -131,8 +131,6 @@ struct mmc_card;
 
 extern void mmc_wait_for_req(struct mmc_host *, struct mmc_request *);
 extern int mmc_wait_for_cmd(struct mmc_host *, struct mmc_command *, int);
-extern int mmc_wait_for_app_cmd(struct mmc_host *, struct mmc_card *,
-	struct mmc_command *, int);
 
 extern void mmc_set_data_timeout(struct mmc_data *, const struct mmc_card *);
 

Re: [2.6 patch] make mmc_wait_for_app_cmd() static

[Pierre Ossman]

On Sun, 13 Apr 2008 21:15:55 +0300
Adrian Bunk <bunk@kernel.org> wrote:

> This patch makes the needlessly global mmc_wait_for_app_cmd() static.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 

Now this one I'm going to have to NAK. We've discussed this one before
and I want to keep it around as part of the API so people don't go
doing silly reimplementations. The embedded crowd tends to work a bit
too much outside mainline, so I want to at least try to nudge them in
directions that keeps their code mergeable.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

Re: [2.6 patch] make mmc_wait_for_app_cmd() static

[Adrian Bunk]

On Wed, Apr 16, 2008 at 07:36:37PM +0200, Pierre Ossman wrote:
> On Sun, 13 Apr 2008 21:15:55 +0300
> Adrian Bunk <bunk@kernel.org> wrote:
> 
> > This patch makes the needlessly global mmc_wait_for_app_cmd() static.
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> > 
> 
> Now this one I'm going to have to NAK. We've discussed this one before
>...

Sorry, I somehow lost the information that we iscussed this before.

> Rgds

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed