* Re: x86: clean up non-smp usage of cpu maps
[not found] <200804181736.m3IHatLo009568@hera.kernel.org>
@ 2008-04-19 1:49 ` Andrew Morton
2008-04-19 2:21 ` Mike Travis
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2008-04-19 1:49 UTC (permalink / raw)
To: Mike Travis; +Cc: Linux Kernel Mailing List
On Fri, 18 Apr 2008 17:36:55 GMT Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> x86: clean up non-smp usage of cpu maps
>
> Cleanup references to the early cpu maps for the non-SMP configuration
> and remove some functions called for SMP configurations only.
>
> ...
>
> index 1179aa0..dc79409 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -10,7 +10,7 @@
> #include <asm/setup.h>
> #include <asm/topology.h>
>
> -#ifdef CONFIG_HAVE_SETUP_PER_CPU_AREA
> +#if defined(CONFIG_HAVE_SETUP_PER_CPU_AREA) && defined(CONFIG_SMP)
This implies that we can have
CONFIG_HAVE_SETUP_PER_CPU_AREA && !CONFIG_SMP
which a) appears to be true and b) seems rather dumb?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: x86: clean up non-smp usage of cpu maps
2008-04-19 1:49 ` x86: clean up non-smp usage of cpu maps Andrew Morton
@ 2008-04-19 2:21 ` Mike Travis
2008-04-19 3:04 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Mike Travis @ 2008-04-19 2:21 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Kernel Mailing List
Andrew Morton wrote:
> On Fri, 18 Apr 2008 17:36:55 GMT Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
>
>> x86: clean up non-smp usage of cpu maps
>>
>> Cleanup references to the early cpu maps for the non-SMP configuration
>> and remove some functions called for SMP configurations only.
>>
>> ...
>>
>> index 1179aa0..dc79409 100644
>> --- a/arch/x86/kernel/setup.c
>> +++ b/arch/x86/kernel/setup.c
>> @@ -10,7 +10,7 @@
>> #include <asm/setup.h>
>> #include <asm/topology.h>
>>
>> -#ifdef CONFIG_HAVE_SETUP_PER_CPU_AREA
>> +#if defined(CONFIG_HAVE_SETUP_PER_CPU_AREA) && defined(CONFIG_SMP)
>
> This implies that we can have
>
> CONFIG_HAVE_SETUP_PER_CPU_AREA && !CONFIG_SMP
>
> which a) appears to be true and b) seems rather dumb?
Yeah, I kind of picked that up in a code merge and didn't really look at it
too closely. I should have checked the Kconfig file to make sure that it
couldn't inadvertently get set if SMP is not set.
Thanks,
Mike
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: x86: clean up non-smp usage of cpu maps
2008-04-19 2:21 ` Mike Travis
@ 2008-04-19 3:04 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2008-04-19 3:04 UTC (permalink / raw)
To: Mike Travis; +Cc: Linux Kernel Mailing List
On Fri, 18 Apr 2008 19:21:50 -0700 Mike Travis <travis@sgi.com> wrote:
> Andrew Morton wrote:
> > On Fri, 18 Apr 2008 17:36:55 GMT Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> >
> >> x86: clean up non-smp usage of cpu maps
> >>
> >> Cleanup references to the early cpu maps for the non-SMP configuration
> >> and remove some functions called for SMP configurations only.
> >>
> >> ...
> >>
> >> index 1179aa0..dc79409 100644
> >> --- a/arch/x86/kernel/setup.c
> >> +++ b/arch/x86/kernel/setup.c
> >> @@ -10,7 +10,7 @@
> >> #include <asm/setup.h>
> >> #include <asm/topology.h>
> >>
> >> -#ifdef CONFIG_HAVE_SETUP_PER_CPU_AREA
> >> +#if defined(CONFIG_HAVE_SETUP_PER_CPU_AREA) && defined(CONFIG_SMP)
> >
> > This implies that we can have
> >
> > CONFIG_HAVE_SETUP_PER_CPU_AREA && !CONFIG_SMP
> >
> > which a) appears to be true and b) seems rather dumb?
>
> Yeah, I kind of picked that up in a code merge and didn't really look at it
> too closely. I should have checked the Kconfig file to make sure that it
> couldn't inadvertently get set if SMP is not set.
config HAVE_SETUP_PER_CPU_AREA
def_bool X86_64 || (X86_SMP && !X86_VOYAGER)
it _can_ get set at present on x86_64, which I assume is incorrect.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-19 3:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200804181736.m3IHatLo009568@hera.kernel.org>
2008-04-19 1:49 ` x86: clean up non-smp usage of cpu maps Andrew Morton
2008-04-19 2:21 ` Mike Travis
2008-04-19 3:04 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome