* Re: + nfsd-use-proc_create-to-setup-de-proc_fops.patch added to -mm tree [not found] <200804152355.m3FNtv3O022485@imap1.linux-foundation.org> @ 2008-04-20 14:37 ` Alexey Dobriyan 2008-04-20 16:21 ` Denis V. Lunev 0 siblings, 1 reply; 3+ messages in thread From: Alexey Dobriyan @ 2008-04-20 14:37 UTC (permalink / raw) To: akpm; +Cc: linux-kernel, den, bfields, ebiederm, neilb On Tue, Apr 15, 2008 at 04:55:57PM -0700, akpm@linux-foundation.org wrote: > --- a/fs/nfsd/nfsctl.c~nfsd-use-proc_create-to-setup-de-proc_fops > +++ a/fs/nfsd/nfsctl.c > @@ -736,10 +737,9 @@ static int create_proc_exports_entry(voi > entry = proc_mkdir("fs/nfs", NULL); > if (!entry) > return -ENOMEM; > - entry = create_proc_entry("fs/nfs/exports", 0, NULL); > + entry = proc_create("exports", 0, entry, &exports_operations); ^^^^^^^^^ > if (!entry) > return -ENOMEM; > - entry->proc_fops = &exports_operations; "fs/nfs/exports" is used in full in this file. And line will fit into 80 columns. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + nfsd-use-proc_create-to-setup-de-proc_fops.patch added to -mm tree 2008-04-20 14:37 ` + nfsd-use-proc_create-to-setup-de-proc_fops.patch added to -mm tree Alexey Dobriyan @ 2008-04-20 16:21 ` Denis V. Lunev 2008-04-20 18:48 ` Alexey Dobriyan 0 siblings, 1 reply; 3+ messages in thread From: Denis V. Lunev @ 2008-04-20 16:21 UTC (permalink / raw) To: Alexey Dobriyan; +Cc: akpm, linux-kernel, bfields, ebiederm, neilb On Sun, 2008-04-20 at 18:37 +0400, Alexey Dobriyan wrote: > On Tue, Apr 15, 2008 at 04:55:57PM -0700, akpm@linux-foundation.org wrote: > > --- a/fs/nfsd/nfsctl.c~nfsd-use-proc_create-to-setup-de-proc_fops > > +++ a/fs/nfsd/nfsctl.c > > > @@ -736,10 +737,9 @@ static int create_proc_exports_entry(voi > > entry = proc_mkdir("fs/nfs", NULL); > > if (!entry) > > return -ENOMEM; > > - entry = create_proc_entry("fs/nfs/exports", 0, NULL); > > + entry = proc_create("exports", 0, entry, &exports_operations); > ^^^^^^^^^ ^^^^^^^ > > if (!entry) > > return -ENOMEM; > > - entry->proc_fops = &exports_operations; > > "fs/nfs/exports" is used in full in this file. And line will fit into > 80 columns. > This is a pde for fs/nfs. So, this will be slightly less operations in my case. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + nfsd-use-proc_create-to-setup-de-proc_fops.patch added to -mm tree 2008-04-20 16:21 ` Denis V. Lunev @ 2008-04-20 18:48 ` Alexey Dobriyan 0 siblings, 0 replies; 3+ messages in thread From: Alexey Dobriyan @ 2008-04-20 18:48 UTC (permalink / raw) To: Denis V. Lunev; +Cc: akpm, linux-kernel, bfields, ebiederm, neilb On Sun, Apr 20, 2008 at 08:21:49PM +0400, Denis V. Lunev wrote: > > On Sun, 2008-04-20 at 18:37 +0400, Alexey Dobriyan wrote: > > On Tue, Apr 15, 2008 at 04:55:57PM -0700, akpm@linux-foundation.org wrote: > > > --- a/fs/nfsd/nfsctl.c~nfsd-use-proc_create-to-setup-de-proc_fops > > > +++ a/fs/nfsd/nfsctl.c > > > > > @@ -736,10 +737,9 @@ static int create_proc_exports_entry(voi > > > entry = proc_mkdir("fs/nfs", NULL); > > > if (!entry) > > > return -ENOMEM; > > > - entry = create_proc_entry("fs/nfs/exports", 0, NULL); > > > + entry = proc_create("exports", 0, entry, &exports_operations); > > ^^^^^^^^^ > ^^^^^^^ > > > if (!entry) > > > return -ENOMEM; > > > - entry->proc_fops = &exports_operations; > > > > "fs/nfs/exports" is used in full in this file. And line will fit into > > 80 columns. > > > This is a pde for fs/nfs. Yes, why change it? > So, this will be slightly less operations in my case. It's done once per module loading, so nobody cares. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-20 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200804152355.m3FNtv3O022485@imap1.linux-foundation.org>
2008-04-20 14:37 ` + nfsd-use-proc_create-to-setup-de-proc_fops.patch added to -mm tree Alexey Dobriyan
2008-04-20 16:21 ` Denis V. Lunev
2008-04-20 18:48 ` Alexey Dobriyan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®