[2.6 patch] remove ata_cable_sata()

[2.6 patch] remove ata_cable_sata()

[Adrian Bunk]

This patch removes the no longer used ata_cable_sata()

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 drivers/ata/libata-core.c |   13 -------------
 include/linux/libata.h    |    1 -
 2 files changed, 14 deletions(-)

7da50f40b2e2a1db9e8d506e65082e90a6eb4ae5 diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index a84df42..0f8807f 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2432,18 +2432,6 @@ int ata_cable_ignore(struct ata_port *ap)
 }
 
 /**
- *	ata_cable_sata	-	return SATA cable type
- *	@ap: port
- *
- *	Helper method for drivers which have SATA cables
- */
-
-int ata_cable_sata(struct ata_port *ap)
-{
-	return ATA_CBL_SATA;
-}
-
-/**
  *	ata_bus_probe - Reset and probe ATA bus
  *	@ap: Bus to probe
  *
@@ -6295,4 +6283,3 @@ EXPORT_SYMBOL_GPL(ata_cable_40wire);
 EXPORT_SYMBOL_GPL(ata_cable_80wire);
 EXPORT_SYMBOL_GPL(ata_cable_unknown);
 EXPORT_SYMBOL_GPL(ata_cable_ignore);
-EXPORT_SYMBOL_GPL(ata_cable_sata);
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 9836213..84618df 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -943,7 +943,6 @@ extern int ata_do_set_mode(struct ata_link *link, struct ata_device **r_failed_d
 
 extern int ata_cable_40wire(struct ata_port *ap);
 extern int ata_cable_80wire(struct ata_port *ap);
-extern int ata_cable_sata(struct ata_port *ap);
 extern int ata_cable_ignore(struct ata_port *ap);
 extern int ata_cable_unknown(struct ata_port *ap);
 

Re: [2.6 patch] remove ata_cable_sata()

[Alan Cox]

On Mon, 21 Apr 2008 11:51:31 +0300
Adrian Bunk <bunk@kernel.org> wrote:

> This patch removes the no longer used ata_cable_sata()
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

NAK - this one is a sensible part of the driver API

Re: [2.6 patch] remove ata_cable_sata()

[Adrian Bunk]

On Wed, Apr 23, 2008 at 07:22:43PM +0100, Alan Cox wrote:
> On Mon, 21 Apr 2008 11:51:31 +0300
> Adrian Bunk <bunk@kernel.org> wrote:
> 
> > This patch removes the no longer used ata_cable_sata()
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> NAK - this one is a sensible part of the driver API

I must have missed something.

I thought that you could simply set .flags in a driver without needing 
any helper for .cable_detect .

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] remove ata_cable_sata()

[Alan Cox]

> I thought that you could simply set .flags in a driver without needing 
> any helper for .cable_detect .

In some cases yes, but exporting the complete set provides a logical and
complete API for drivers in case they do need to do so.