mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [2.6 patch] make struct o2cb_stack_ops static
@ 2008-04-21  8:49 Adrian Bunk
  2008-04-21 10:02 ` Joel Becker
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-04-21  8:49 UTC (permalink / raw)
  To: Joel Becker, Mark Fasheh; +Cc: ocfs2-devel, linux-kernel

This patch makes the needlessly global struct o2cb_stack_ops static.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
eb3ca85e31f3ddec51aaab0fd2243962d7ce1bc6 diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c
index ac1d74c..bbd1667 100644
--- a/fs/ocfs2/stack_o2cb.c
+++ b/fs/ocfs2/stack_o2cb.c
@@ -385,7 +385,7 @@ static int o2cb_cluster_this_node(unsigned int *node)
 	return 0;
 }
 
-struct ocfs2_stack_operations o2cb_stack_ops = {
+static struct ocfs2_stack_operations o2cb_stack_ops = {
 	.connect	= o2cb_cluster_connect,
 	.disconnect	= o2cb_cluster_disconnect,
 	.hangup		= o2cb_cluster_hangup,


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.6 patch] make struct o2cb_stack_ops static
  2008-04-21  8:49 [2.6 patch] make struct o2cb_stack_ops static Adrian Bunk
@ 2008-04-21 10:02 ` Joel Becker
  0 siblings, 0 replies; 2+ messages in thread
From: Joel Becker @ 2008-04-21 10:02 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Mark Fasheh, ocfs2-devel, linux-kernel

On Mon, Apr 21, 2008 at 11:49:31AM +0300, Adrian Bunk wrote:
> This patch makes the needlessly global struct o2cb_stack_ops static.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Joel Becker <joel.becker@oracle.com>

> 
> ---
> eb3ca85e31f3ddec51aaab0fd2243962d7ce1bc6 diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c
> index ac1d74c..bbd1667 100644
> --- a/fs/ocfs2/stack_o2cb.c
> +++ b/fs/ocfs2/stack_o2cb.c
> @@ -385,7 +385,7 @@ static int o2cb_cluster_this_node(unsigned int *node)
>  	return 0;
>  }
>  
> -struct ocfs2_stack_operations o2cb_stack_ops = {
> +static struct ocfs2_stack_operations o2cb_stack_ops = {
>  	.connect	= o2cb_cluster_connect,
>  	.disconnect	= o2cb_cluster_disconnect,
>  	.hangup		= o2cb_cluster_hangup,
> 

-- 

"What does it say about a society's priorities when the time you
 spend in meetings on Monday is greater than the total number of
 hours you spent sleeping over the weekend?"
	- Nat Friedman

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-04-21 10:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-21  8:49 [2.6 patch] make struct o2cb_stack_ops static Adrian Bunk
2008-04-21 10:02 ` Joel Becker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®