False positive in checkpatch (2.6.25)

False positive in checkpatch (2.6.25)

[Alan Stern]

Here's the patch:

------------------------------------------------------
--- usb-2.6.orig/drivers/usb/core/driver.c
+++ usb-2.6/drivers/usb/core/driver.c
@@ -1541,14 +1541,11 @@ static int usb_resume(struct device *dev
 	udev = to_usb_device(dev);
 
 	/* If udev->skip_sys_resume is set then udev was already suspended
-	 * when the system suspend started, so we don't want to resume
-	 * udev during this system wakeup.  However a reset-resume counts
-	 * as a wakeup event, so allow a reset-resume to occur if remote
-	 * wakeup is enabled. */
-	if (udev->skip_sys_resume) {
-		if (!(udev->reset_resume && udev->do_remote_wakeup))
-			return -EHOSTUNREACH;
-	}
+	 * when the system suspend started, so we don't want to resume it
+	 * during this system wakeup.
+	 */
+	if (udev->skip_sys_resume)
+		return 0;
 	return usb_external_resume_device(udev);
 }
 
------------------------------------------------------

And here's the output from checkpatch.pl:

------------------------------------------------------
ERROR: space prohibited after that '*' (ctx:ExW)
#15: FILE: drivers/usb/core/driver.c:1544:
+        * when the system suspend started, so we don't want to resume it
         ^

ERROR: Missing Signed-off-by: line(s)

total: 2 errors, 0 warnings, 19 lines checked

/tmp/t has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
------------------------------------------------------

Alan Stern

Re: False positive in checkpatch (2.6.25)

[Andy Whitcroft]

On Thu, Apr 17, 2008 at 03:33:48PM -0400, Alan Stern wrote:

> ERROR: space prohibited after that '*' (ctx:ExW)
> #15: FILE: drivers/usb/core/driver.c:1544:
> +        * when the system suspend started, so we don't want to resume it
>          ^
> 
> ERROR: Missing Signed-off-by: line(s)

Yes, pretty sure that was triggered by a bug in comment tracking when
it moved into quote tracking.  From my testing here it should have been
fixed in v0.17, you have v0.16.  Andrew has the change queued up so it
should be on its way to mainline.  You can get the latest from the url
below to confirm:

	http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/

Thanks for the report.

-apw

Re: False positive in checkpatch (2.6.25)

[Alan Stern]

On Tue, 22 Apr 2008, Andy Whitcroft wrote:

> On Thu, Apr 17, 2008 at 03:33:48PM -0400, Alan Stern wrote:
> 
> > ERROR: space prohibited after that '*' (ctx:ExW)
> > #15: FILE: drivers/usb/core/driver.c:1544:
> > +        * when the system suspend started, so we don't want to resume it
> >          ^
> > 
> > ERROR: Missing Signed-off-by: line(s)
> 
> Yes, pretty sure that was triggered by a bug in comment tracking when
> it moved into quote tracking.  From my testing here it should have been
> fixed in v0.17, you have v0.16.  Andrew has the change queued up so it
> should be on its way to mainline.  You can get the latest from the url
> below to confirm:
> 
> 	http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/
> 
> Thanks for the report.

Confirmed: checkpatch.pl-next doesn't have this problem.

Alan Stern