mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* mac80211/wme.c: check-after-use
@ 2008-04-23  9:51 Adrian Bunk
  2008-04-23 10:20 ` Rindjunsky, Ron
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-04-23  9:51 UTC (permalink / raw)
  To: Ron Rindjunsky, John W. Linville; +Cc: linux-wireless, netdev, linux-kernel

The Coverity checker spotted the following check-after-use of the 
"qdisc" variable in net/mac80211/wme.c introduced by
commit 9e7234923789897858e1a475c579b5e2e6ad5b74
(mac80211: A-MPDU Tx adding qdisc support):

<--  snip  -->

...
void ieee80211_requeue(struct ieee80211_local *local, int queue)
{
        struct Qdisc *root_qd = local->mdev->qdisc_sleeping;
        struct ieee80211_sched_data *q = qdisc_priv(root_qd);
        struct Qdisc *qdisc = q->queues[queue];
        struct sk_buff *skb = NULL;
        u32 len = qdisc->q.qlen;    <------

        if (!qdisc || !qdisc->dequeue)
                return;
...

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-04-23 10:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-23  9:51 mac80211/wme.c: check-after-use Adrian Bunk
2008-04-23 10:20 ` Rindjunsky, Ron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®