mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Abbott <michael@araneidae.co.uk>
To: Daniel Mack <daniel@caiaq.org>, linux-arm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Colibri: Fix support for DM9000 ethernet device.
Date: Thu, 24 Apr 2008 10:13:09 +0000 (GMT)	[thread overview]
Message-ID: <20080424095917.Q51356@saturn.araneidae.co.uk> (raw)

From: Michael Abbott <michael.abbott@diamond.ac.uk>

Colibri: Fix support for DM9000 ethernet device.

Two changes are necessary to enable proper operation of the DM9000 device
with the Colibri PXA 270 board: firstly, the IRQ type needs to be
configured for rising edge interrupts, and secondly this configuration needs
to be communicated through to the DM9000.

Signed-off-by: Michael Abbott <michael.abbott@diamond.ac.uk>
---
  arch/arm/mach-pxa/colibri.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

Patch applied against v2.6.25

Proper operation of this device also depends on the DM9000 timer patch 
submitted separately.

diff --git a/arch/arm/mach-pxa/colibri.c b/arch/arm/mach-pxa/colibri.c
index 6db54e3..a76f95a 100644
--- a/arch/arm/mach-pxa/colibri.c
+++ b/arch/arm/mach-pxa/colibri.c
@@ -97,7 +97,7 @@ static struct resource dm9000_resources[] = {
  	[2] = {
  		.start	= COLIBRI_ETH_IRQ,
  		.end	= COLIBRI_ETH_IRQ,
-		.flags	= IORESOURCE_IRQ,
+		.flags	= IORESOURCE_IRQ | IRQF_TRIGGER_RISING,
  	},
  };

@@ -118,7 +118,7 @@ static void __init colibri_init(void)
  	/* DM9000 LAN */
  	pxa_gpio_mode(GPIO78_nCS_2_MD);
  	pxa_gpio_mode(GPIO_DM9000 | GPIO_IN);
-	set_irq_type(COLIBRI_ETH_IRQ, IRQT_FALLING);
+	set_irq_type(COLIBRI_ETH_IRQ, IRQT_RISING);

  	platform_add_devices(colibri_devices, ARRAY_SIZE(colibri_devices));
  }
-- 
1.5.5


             reply	other threads:[~2008-04-24 10:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24 10:13 Michael Abbott [this message]
2008-04-24 10:24 ` Daniel Mack
2008-04-24 11:28 ` Ben Dooks
2008-04-24 12:24   ` Michael Abbott
2008-04-26 18:34     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080424095917.Q51356@saturn.araneidae.co.uk \
    --to=michael@araneidae.co.uk \
    --cc=daniel@caiaq.org \
    --cc=linux-arm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®