From: Michael Abbott <michael@araneidae.co.uk>
To: Ben Dooks <ben-linux@fluff.org>
Cc: Daniel Mack <daniel@caiaq.org>,
linux-arm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Colibri: Fix support for DM9000 ethernet device.
Date: Thu, 24 Apr 2008 12:24:43 +0000 (GMT) [thread overview]
Message-ID: <20080424122203.B52164@saturn.araneidae.co.uk> (raw)
In-Reply-To: <20080424112858.GD16284@fluff.org.uk>
On Thu, 24 Apr 2008, Ben Dooks wrote:
> On Thu, Apr 24, 2008 at 10:13:09AM +0000, Michael Abbott wrote:
>> From: Michael Abbott <michael.abbott@diamond.ac.uk>
>>
>> Colibri: Fix support for DM9000 ethernet device.
>> diff --git a/arch/arm/mach-pxa/colibri.c b/arch/arm/mach-pxa/colibri.c
>> --- a/arch/arm/mach-pxa/colibri.c
>> +++ b/arch/arm/mach-pxa/colibri.c
>> @@ -118,7 +118,7 @@ static void __init colibri_init(void)
>> /* DM9000 LAN */
>> pxa_gpio_mode(GPIO78_nCS_2_MD);
>> pxa_gpio_mode(GPIO_DM9000 | GPIO_IN);
>> - set_irq_type(COLIBRI_ETH_IRQ, IRQT_FALLING);
>> + set_irq_type(COLIBRI_ETH_IRQ, IRQT_RISING);
>
> The set_irq_type() call here should be removed.
I can confirm that Ben is right, and that the set_irq_type call can be
removed.
What is the procedure here? Do I submit a new patch to supersede the old
one?
next prev parent reply other threads:[~2008-04-24 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 10:13 Michael Abbott
2008-04-24 10:24 ` Daniel Mack
2008-04-24 11:28 ` Ben Dooks
2008-04-24 12:24 ` Michael Abbott [this message]
2008-04-26 18:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424122203.B52164@saturn.araneidae.co.uk \
--to=michael@araneidae.co.uk \
--cc=ben-linux@fluff.org \
--cc=daniel@caiaq.org \
--cc=linux-arm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®