From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Alexander van Heukelum <heukelum@mailshack.com>
Subject: Re: [git pull] generic bitops, take 2
Date: Sat, 26 Apr 2008 19:34:50 +0200 [thread overview]
Message-ID: <20080426173450.GB29451@uranus.ravnborg.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0804260955300.2813@woody.linux-foundation.org>
On Sat, Apr 26, 2008 at 10:03:31AM -0700, Linus Torvalds wrote:
>
>
> On Sat, 26 Apr 2008, Ingo Molnar wrote:
> >
> > i've added Alexander's patch that does the cleanup suggested by you
>
> Well.. Not really:
>
> > diff --git a/arch/um/Kconfig.x86_64 b/arch/um/Kconfig.x86_64
> > index 3fbe69e..7a75043 100644
> > --- a/arch/um/Kconfig.x86_64
> > +++ b/arch/um/Kconfig.x86_64
> > @@ -27,6 +27,14 @@ config SMP_BROKEN
> > bool
> > default y
> >
> > +config GENERIC_FIND_FIRST_BIT
> > + bool
> > + default y
> > +
> > +config GENERIC_FIND_NEXT_BIT
> > + bool
> > + default y
> > +
>
> It still declares this GENERIC_FIND_*_BIT thing separately for UM.
It would be nice if this could follow the sample outlined
in Documentation/kbuild/kconfig-language.txt.
See the section about HAVE_
Basically we should only define the config symbol once in all
the Kconfig files and where we then want to use this function
we should select the config symbol.
Sam
prev parent reply other threads:[~2008-04-26 17:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 21:57 [git pull] generic bitops Ingo Molnar
2008-04-24 22:14 ` Linus Torvalds
2008-04-24 22:41 ` Harvey Harrison
2008-04-25 11:12 ` [PATCH] x86, bitops: select the generic bitmap search functions Alexander van Heukelum
2008-04-26 15:15 ` [git pull] generic bitops, take 2 Ingo Molnar
2008-04-26 17:03 ` Linus Torvalds
2008-04-26 17:22 ` Ingo Molnar
2008-04-26 17:28 ` Ingo Molnar
2008-04-26 17:50 ` [git pull] generic bitops, take 3 Ingo Molnar
2008-04-26 17:32 ` [git pull] generic bitops, take 2 Sam Ravnborg
2008-04-26 17:51 ` Miklos Vajna
2008-04-28 15:38 ` [2.6 patch] mm/filemap.c:generic_write_checks() mustn't be inline Adrian Bunk
2008-04-28 15:38 ` [2.6 patch] fs/buffer.c:init_buffer() " Adrian Bunk
2008-04-28 16:01 ` Linus Torvalds
2008-04-28 16:48 ` Adrian Bunk
2008-04-28 16:58 ` Linus Torvalds
2008-04-28 15:38 ` [2.6 patch] fs/block_dev.c:I_BDEV() " Adrian Bunk
2008-04-29 0:41 ` Linus Torvalds
2008-04-29 1:12 ` Al Viro
2008-04-29 1:21 ` Linus Torvalds
2008-04-29 2:32 ` Jeff Dike
2008-04-29 4:57 ` Sam Ravnborg
2008-04-29 8:06 ` Adrian Bunk
2008-04-29 8:17 ` Sam Ravnborg
2008-04-29 9:03 ` Adrian Bunk
2008-04-28 15:38 ` [2.6 patch] block/blk-barrier.c:blk_ordered_cur_seq() " Adrian Bunk
2008-04-29 7:46 ` Jens Axboe
2008-04-28 15:38 ` [2.6 patch] net/ipv4/ip_output.c:ip_send_check() " Adrian Bunk
2008-04-28 15:38 ` [2.6 patch] reiserfs: some functions " Adrian Bunk
2008-04-29 22:43 ` Edward Shishkin
2008-04-28 15:38 ` [2.6 patch] fs/udf/partition.c:udf_get_pblock() " Adrian Bunk
2008-04-28 16:47 ` Jan Kara
2008-04-28 17:26 ` [git pull] generic bitops, take 2 Jeff Dike
2008-04-26 17:34 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080426173450.GB29451@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=heukelum@mailshack.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®