mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Adrian Bunk <bunk@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Alexander van Heukelum <heukelum@mailshack.com>,
	jdike@addtoit.com, Ingo Molnar <mingo@elte.hu>
Subject: Re: [2.6 patch] fs/udf/partition.c:udf_get_pblock() mustn't be inline
Date: Mon, 28 Apr 2008 18:47:31 +0200	[thread overview]
Message-ID: <20080428164731.GG17054@duck.suse.cz> (raw)
In-Reply-To: <20080428153849.GH2813@cs181133002.pp.htv.fi>

On Mon 28-04-08 18:38:49, Adrian Bunk wrote:
> This patch fixes the following build error with UML and gcc 4.3:
> 
> <--  snip  -->
> 
> ...
>   CC      fs/udf/partition.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/udf/partition.c: In function ‘udf_get_pblock_virt15’:
> /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/udf/partition.c:32: sorry, unimplemented: inlining failed in call to ‘udf_get_pblock’: function body not available
> /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/udf/partition.c:102: sorry, unimplemented: called from here
> make[3]: *** [fs/udf/partition.o] Error 1
> 
> <--  snip  -->
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
  Thanks. Merged into UDF git tree.

										Honza

> ---
> 9739b5f94fdf781f71cbb4c7b2f8f6d9e3d58e55 diff --git a/fs/udf/partition.c b/fs/udf/partition.c
> index 63610f0..96dfd20 100644
> --- a/fs/udf/partition.c
> +++ b/fs/udf/partition.c
> @@ -27,8 +27,8 @@
>  #include <linux/slab.h>
>  #include <linux/buffer_head.h>
>  
> -inline uint32_t udf_get_pblock(struct super_block *sb, uint32_t block,
> -			       uint16_t partition, uint32_t offset)
> +uint32_t udf_get_pblock(struct super_block *sb, uint32_t block,
> +			uint16_t partition, uint32_t offset)
>  {
>  	struct udf_sb_info *sbi = UDF_SB(sb);
>  	struct udf_part_map *map;
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2008-04-28 16:47 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24 21:57 [git pull] generic bitops Ingo Molnar
2008-04-24 22:14 ` Linus Torvalds
2008-04-24 22:41   ` Harvey Harrison
2008-04-25 11:12   ` [PATCH] x86, bitops: select the generic bitmap search functions Alexander van Heukelum
2008-04-26 15:15   ` [git pull] generic bitops, take 2 Ingo Molnar
2008-04-26 17:03     ` Linus Torvalds
2008-04-26 17:22       ` Ingo Molnar
2008-04-26 17:28         ` Ingo Molnar
2008-04-26 17:50           ` [git pull] generic bitops, take 3 Ingo Molnar
2008-04-26 17:32         ` [git pull] generic bitops, take 2 Sam Ravnborg
2008-04-26 17:51         ` Miklos Vajna
2008-04-28 15:38         ` [2.6 patch] mm/filemap.c:generic_write_checks() mustn't be inline Adrian Bunk
2008-04-28 15:38         ` [2.6 patch] fs/buffer.c:init_buffer() " Adrian Bunk
2008-04-28 16:01           ` Linus Torvalds
2008-04-28 16:48             ` Adrian Bunk
2008-04-28 16:58               ` Linus Torvalds
2008-04-28 15:38         ` [2.6 patch] fs/block_dev.c:I_BDEV() " Adrian Bunk
2008-04-29  0:41           ` Linus Torvalds
2008-04-29  1:12             ` Al Viro
2008-04-29  1:21               ` Linus Torvalds
2008-04-29  2:32             ` Jeff Dike
2008-04-29  4:57               ` Sam Ravnborg
2008-04-29  8:06             ` Adrian Bunk
2008-04-29  8:17               ` Sam Ravnborg
2008-04-29  9:03                 ` Adrian Bunk
2008-04-28 15:38         ` [2.6 patch] block/blk-barrier.c:blk_ordered_cur_seq() " Adrian Bunk
2008-04-29  7:46           ` Jens Axboe
2008-04-28 15:38         ` [2.6 patch] net/ipv4/ip_output.c:ip_send_check() " Adrian Bunk
2008-04-28 15:38         ` [2.6 patch] reiserfs: some functions " Adrian Bunk
2008-04-29 22:43           ` Edward Shishkin
2008-04-28 15:38         ` [2.6 patch] fs/udf/partition.c:udf_get_pblock() " Adrian Bunk
2008-04-28 16:47           ` Jan Kara [this message]
2008-04-28 17:26         ` [git pull] generic bitops, take 2 Jeff Dike
2008-04-26 17:34       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428164731.GG17054@duck.suse.cz \
    --to=jack@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=heukelum@mailshack.com \
    --cc=hpa@zytor.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®