* [PATCH] fix uninitialized variable warning in crypto/async_tx/async_tx.c
@ 2008-04-27 7:12 Chris Peterson
2008-04-27 7:17 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Chris Peterson @ 2008-04-27 7:12 UTC (permalink / raw)
To: linux-kernel
This patch against linux-2.6.25-git7.
/mnt/westside/vol/silver/cpeterso/tmp/linux/linux-2.6.25/crypto/async_tx/async_tx.c:
In function `async_trigger_callback':
/mnt/westside/vol/silver/cpeterso/tmp/linux/linux-2.6.25/crypto/async_tx/async_tx.c:584:
warning: `chan' might be used uninitialized in this function
chris
Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
---
diff -Naur linux-2.6.25-git7/crypto/async_tx/async_tx.c
linux-2.6.25-git7+patch/crypto/async_tx/async_tx.c
--- linux-2.6.25-git7/crypto/async_tx/async_tx.c 2008-04-25
22:46:24.000000000 -0700
+++ linux-2.6.25-git7+patch/crypto/async_tx/async_tx.c 2008-04-25
23:39:44.000000000 -0700
@@ -596,8 +596,11 @@
device = NULL;
tx = device ? device->device_prep_dma_interrupt(chan, 0) : NULL;
- } else
+ } else {
+ chan = NULL;
+ device = NULL;
tx = NULL;
+ }
if (tx) {
pr_debug("%s: (async)\n", __func__);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fix uninitialized variable warning in crypto/async_tx/async_tx.c 2008-04-27 7:12 [PATCH] fix uninitialized variable warning in crypto/async_tx/async_tx.c Chris Peterson @ 2008-04-27 7:17 ` David Miller 2008-04-28 5:04 ` [PATCH] fix uninitialized variable warning in crypto/async_tx/async_tx.c (fixed?) Chris Peterson 0 siblings, 1 reply; 4+ messages in thread From: David Miller @ 2008-04-27 7:17 UTC (permalink / raw) To: cpeterso; +Cc: linux-kernel From: "Chris Peterson" <cpeterso@cpeterso.com> Date: Sun, 27 Apr 2008 00:12:22 -0700 > --- linux-2.6.25-git7/crypto/async_tx/async_tx.c 2008-04-25 > 22:46:24.000000000 -0700 Chris, your email client is adding line breaks and other transformation which are corrupting the patches you are sending. Please correct this and resubmit your patch. Thanks. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix uninitialized variable warning in crypto/async_tx/async_tx.c (fixed?) 2008-04-27 7:17 ` David Miller @ 2008-04-28 5:04 ` Chris Peterson 2008-04-28 6:33 ` David Miller 0 siblings, 1 reply; 4+ messages in thread From: Chris Peterson @ 2008-04-28 5:04 UTC (permalink / raw) To: David Miller; +Cc: linux-kernel oops, sorry. Let me try this again. chris --- diff -Naur linux-2.6.25-git7/crypto/async_tx/async_tx.c linux-2.6.25- git7+patch/crypto/async_tx/async_tx.c --- linux-2.6.25-git7/crypto/async_tx/async_tx.c 2008-04-25 22:46:24.000000000 -0700 +++ linux-2.6.25-git7+patch/crypto/async_tx/async_tx.c 2008-04-25 23:39:44.000000000 -0700 @@ -596,8 +596,11 @@ device = NULL; tx = device ? device->device_prep_dma_interrupt (chan, 0) : NULL; - } else + } else { + chan = NULL; + device = NULL; tx = NULL; + } if (tx) { pr_debug("%s: (async)\n", __func__); ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix uninitialized variable warning in crypto/async_tx/async_tx.c (fixed?) 2008-04-28 5:04 ` [PATCH] fix uninitialized variable warning in crypto/async_tx/async_tx.c (fixed?) Chris Peterson @ 2008-04-28 6:33 ` David Miller 0 siblings, 0 replies; 4+ messages in thread From: David Miller @ 2008-04-28 6:33 UTC (permalink / raw) To: cpeterso; +Cc: linux-kernel From: Chris Peterson <cpeterso@cpeterso.com> Date: Sun, 27 Apr 2008 22:04:33 -0700 > oops, sorry. Let me try this again. Same problem. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-04-28 6:33 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2008-04-27 7:12 [PATCH] fix uninitialized variable warning in crypto/async_tx/async_tx.c Chris Peterson 2008-04-27 7:17 ` David Miller 2008-04-28 5:04 ` [PATCH] fix uninitialized variable warning in crypto/async_tx/async_tx.c (fixed?) Chris Peterson 2008-04-28 6:33 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®