mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Sergio Luis <sergio@uece.br>
Cc: Glauber de Oliveira Costa <gcosta@redhat.com>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	tglx@linutronix.de, ak@suse.de, Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] build fix for smp
Date: Mon, 28 Apr 2008 10:50:44 +0200	[thread overview]
Message-ID: <20080428085044.GB16963@elte.hu> (raw)
In-Reply-To: <ce0170d90804280052y130c3fa2pbf3f97147f03b159@mail.gmail.com>


* Sergio Luis <sergio@uece.br> wrote:

> Hello, what's the final fix for this issue? 2.6.25-git11 is still 
> broken, just gave me

> arch/x86/kernel/built-in.o: In function `native_smp_send_stop':
> smp.c:(.text+0xc751): undefined reference to `reboot_force'
> make: *** [.tmp_vmlinux1] Error 1

> for a randconfig. Same reported at http://lkml.org/lkml/2008/4/27/39

btw., that's a VISWS config - that wont boot on any PC. The patch below 
should fix this.

	Ingo

--------------------------->
Subject: x86 VISWS: build fix
From: Ingo Molnar <mingo@elte.hu>
Date: Mon Apr 28 10:46:58 CEST 2008

the 'reboot_force' flag is a notion that non-PC subarchitectures do
not have.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/asm-x86/proto.h |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux/include/asm-x86/proto.h
===================================================================
--- linux.orig/include/asm-x86/proto.h
+++ linux/include/asm-x86/proto.h
@@ -20,7 +20,11 @@ extern void syscall32_cpu_init(void);
 
 extern void check_efer(void);
 
+#ifdef X86_BIOS_REBOOT
 extern int reboot_force;
+#else
+static const int reboot_force = 0;
+#endif
 
 long do_arch_prctl(struct task_struct *task, int code, unsigned long addr);
 

  reply	other threads:[~2008-04-28  8:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-19 17:11 Glauber de Oliveira Costa
2008-03-19 19:52 ` Ingo Molnar
2008-04-28  7:52   ` Sergio Luis
2008-04-28  8:50     ` Ingo Molnar [this message]
2008-04-28  9:01       ` Sergio Luis
2008-04-28 14:16     ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428085044.GB16963@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=avi@qumranet.com \
    --cc=gcosta@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergio@uece.br \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®