mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Sergio Luis" <sergio@uece.br>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Glauber de Oliveira Costa" <gcosta@redhat.com>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	tglx@linutronix.de, ak@suse.de
Subject: Re: [PATCH] build fix for smp
Date: Mon, 28 Apr 2008 04:52:11 -0300	[thread overview]
Message-ID: <ce0170d90804280052y130c3fa2pbf3f97147f03b159@mail.gmail.com> (raw)
In-Reply-To: <20080319195217.GA20762@elte.hu>

On Wed, Mar 19, 2008 at 4:52 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
>  * Glauber de Oliveira Costa <gcosta@redhat.com> wrote:
>
>  > +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_BIOS_REBOOT)
>  >       if (reboot_force)
>  >               return;
>  > +#endif
>
>  please solve it slightly differently: introduce a uniformly usable
>  reboot_force flag, that will always default to the constant of 1 if
>  !X86_64 && !X86_BIOS_REBOOT. That makes the code cleaner - and not the
>  least i can also merge the fix earlier in the series, without having to
>  redo the big smp.c movement patch :-)
>
>         Ingo
>

Hello,
what's the final fix for this issue? 2.6.25-git11 is still broken, just gave me

arch/x86/kernel/built-in.o: In function `native_smp_send_stop':
smp.c:(.text+0xc751): undefined reference to `reboot_force'
make: *** [.tmp_vmlinux1] Error 1

for a randconfig. Same reported at http://lkml.org/lkml/2008/4/27/39

thanks,
-sergio

  reply	other threads:[~2008-04-28  7:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-19 17:11 Glauber de Oliveira Costa
2008-03-19 19:52 ` Ingo Molnar
2008-04-28  7:52   ` Sergio Luis [this message]
2008-04-28  8:50     ` Ingo Molnar
2008-04-28  9:01       ` Sergio Luis
2008-04-28 14:16     ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce0170d90804280052y130c3fa2pbf3f97147f03b159@mail.gmail.com \
    --to=sergio@uece.br \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=gcosta@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome