From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Tadeusz Gozdek <linux_fan@o2.pl>
Cc: linux-kernel@vger.kernel.org, marcel@holtmann.org
Subject: Re: Fwd: [PATCH] [MMC] fix clock problem in PXA255/270
Date: Tue, 29 Apr 2008 11:39:46 +0200 [thread overview]
Message-ID: <20080429113946.1ba93ef5@mjolnir.drzeus.cx> (raw)
In-Reply-To: <61fb248d.11640040.4816c4ed.cc@o2.pl>
On Tue, 29 Apr 2008 08:49:17 +0200
Tadeusz Gozdek <linux_fan@o2.pl> wrote:
> Hi
> As you can check, after finishing all operations clock is leaved as switched on (its switched off and on again during sending next command e.g. GO_INACTIVE_STATE). The same is after wake-up the system, even if the clock was switched off.
> Switched on clock has sometimes an influence on the rest of the hardware e.g. the GPS modules and on battery life in a battery powered systems.
>
That is a policy with possible side-effects (i.e. needs to be
configurable), and host independent so it should be in the core. So I'm
afraid I have to NAK your patch.
As a side-note, the PXA driver shouldn't be fiddling with the clock the
way it does right now in the first place, but I have no maintainer to
yell at. Patches removing that behaviour are very welcome.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
next prev parent reply other threads:[~2008-04-29 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 7:32 Tadeusz Gozdek
2008-04-28 13:28 ` Pierre Ossman
2008-04-29 6:49 ` Tadeusz Gozdek
2008-04-29 9:39 ` Pierre Ossman [this message]
2008-04-29 10:30 ` Tadeusz Gozdek
2008-04-29 16:22 ` Pierre Ossman
2008-04-30 8:43 ` Tadeusz Gozdek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429113946.1ba93ef5@mjolnir.drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_fan@o2.pl \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®