From: "Tadeusz Gozdek" <linux_fan@o2.pl>
To: linux-kernel@vger.kernel.org
Cc: "Marcel Holtmann" <marcel@holtmann.org>,
"Pierre Ossman" <drzeus-list@drzeus.cx>
Subject: Fwd: [PATCH] [MMC] fix clock problem in PXA255/270
Date: Mon, 28 Apr 2008 09:32:49 +0200 [thread overview]
Message-ID: <441f2104.26c7abf7.48157da1.e45c7@o2.pl> (raw)
It solves the problems with clock in the PXA255/270 MMC/SD hardware.
This solution was testes with our devices and works good.
Kernel 2.6.24.4 (but should work with >=2.6.19)
Regards
Tadeusz Gozdek
diff -NuarBb /x/work/navi_os/mmc/host/pxamci.c mmc/host/pxamci.c
--- /x/work/navi_os/mmc/host/pxamci.c 2008-03-24 19:49:18.000000000 +0100
+++ mmc/host/pxamci.c 2008-04-25 12:14:00.000000000 +0200
@@ -26,6 +26,7 @@
#include <linux/clk.h>
#include <linux/err.h>
#include <linux/mmc/host.h>
+#include <linux/mmc/mmc.h>
#include <asm/dma.h>
#include <asm/io.h>
@@ -67,6 +68,8 @@
unsigned int dma_dir;
};
+static int local_cmd = -1;
+
static void pxamci_stop_clock(struct pxamci_host *host)
{
if (readl(host->base + MMC_STAT) & STAT_CLK_EN) {
@@ -84,6 +87,7 @@
if (v & STAT_CLK_EN)
dev_err(mmc_dev(host->mmc), "unable to stop clock\n");
+ local_cmd = -1;
}
}
@@ -232,6 +235,14 @@
v = w2;
}
+ local_cmd = cmd->opcode;
+ if ((local_cmd == MMC_GO_IDLE_STATE) ||
+ (local_cmd == MMC_GO_INACTIVE_STATE) ||
+ (local_cmd == MMC_SEND_STATUS) ||
+ (local_cmd == MMC_STOP_TRANSMISSION) ||
+ (local_cmd == MMC_SET_BLOCKLEN)
+ ) pxamci_stop_clock(host);
+
if (stat & STAT_TIME_OUT_RESPONSE) {
cmd->error = -ETIMEDOUT;
} else if (stat & STAT_RES_CRC_ERR && cmd->flags & MMC_RSP_CRC) {
@@ -290,7 +301,7 @@
host->data = NULL;
if (host->mrq->stop) {
- pxamci_stop_clock(host);
+ //pxamci_stop_clock(host);
pxamci_start_cmd(host, host->mrq->stop, host->cmdat);
} else {
pxamci_finish_request(host, host->mrq);
next reply other threads:[~2008-04-28 7:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 7:32 Tadeusz Gozdek [this message]
2008-04-28 13:28 ` Pierre Ossman
2008-04-29 6:49 ` Tadeusz Gozdek
2008-04-29 9:39 ` Pierre Ossman
2008-04-29 10:30 ` Tadeusz Gozdek
2008-04-29 16:22 ` Pierre Ossman
2008-04-30 8:43 ` Tadeusz Gozdek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441f2104.26c7abf7.48157da1.e45c7@o2.pl \
--to=linux_fan@o2.pl \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®