mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: kosaki.motohiro@jp.fujitsu.com, Shi Weihua <shiwh@cn.fujitsu.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] on memoryless node, /proc/pagetypeinfo is displayed slightly funny output.  take2
Date: Tue, 29 Apr 2008 20:11:26 +0900	[thread overview]
Message-ID: <20080429200710.354B.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20080429104318.GA9622@csn.ul.ie>

> I see what you mean. The headers for a node with no populated zones looks
> a bit odd. I was briefly thrown by the check for N_HIGH_MEMORY wondering
> why it was not a check for N_NORMAL_MEMORY. A double-check showed that
> N_NORMAL_MEMORY only has meaning on CONFIG_HIGHMEM machines and a check for
> "any memory on the node" should use N_HIGH_MEMORY which is what you do.
> 
> So, your patch looks correct but unfortunately it is whitespace-damaged
> and would not apply as-is. I included a whitespace-fixed version below for
> convenience with a slightly clearer leader which I have acked.

Oops, very sorry.
I'll check my MUA settings again.

and, very thank you for your excellent cleanups.




      reply	other threads:[~2008-04-29 11:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-29  7:40 [PATCH] on memoryless node, /proc/pagetypeinfo is displayed slightly funny output KOSAKI Motohiro
2008-04-29  8:12 ` Shi Weihua
2008-04-29  8:17   ` [PATCH] on memoryless node, /proc/pagetypeinfo is displayed slightly funny output. take2 KOSAKI Motohiro
2008-04-29 10:43     ` Mel Gorman
2008-04-29 11:11       ` KOSAKI Motohiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080429200710.354B.KOSAKI.MOTOHIRO@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mel@csn.ul.ie \
    --cc=shiwh@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®