linux-next: upstream build failure: pasemi_edac

linux-next: upstream build failure: pasemi_edac

[Stephen Rothwell]

Hi all,

Today's linux-next build (just Linus' tree, powercp ppc64_defconfig)
fails like this:

drivers/edac/pasemi_edac.c: In function 'pasemi_edac_init':
drivers/edac/pasemi_edac.c:288: error: implicit declaration of function 'opstate_init'
drivers/edac/pasemi_edac.c: In function '__check_edac_op_state':
drivers/edac/pasemi_edac.c:304: error: 'edac_op_state' undeclared (first use in this function)
drivers/edac/pasemi_edac.c:304: error: (Each undeclared identifier is reported only once
drivers/edac/pasemi_edac.c:304: error: for each function it appears in.)
drivers/edac/pasemi_edac.c: At top level:
drivers/edac/pasemi_edac.c:304: error: 'edac_op_state' undeclared here (not in a function)

Caused by commit c3c52bce6993c6d37af2c2de9b482a7013d646a7 ("edac: fix
module initialization on several modules 2nd time") which added a call to
opstate_init but did not include linux/edac.h that declares it.

Patch below.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 30 Apr 2008 11:16:16 +1000
Subject: [PATCH] pasemi_edac needs to include linux/edac.h

Commit c3c52bce6993c6d37af2c2de9b482a7013d646a7 ("edac: fix module
initialization on several modules 2nd time") added a call to opstate_init
but did not include linux/edac.h that declares it.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/edac/pasemi_edac.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/edac/pasemi_edac.c b/drivers/edac/pasemi_edac.c
index 3fd65a5..8e6b91b 100644
--- a/drivers/edac/pasemi_edac.c
+++ b/drivers/edac/pasemi_edac.c
@@ -26,6 +26,7 @@
 #include <linux/pci.h>
 #include <linux/pci_ids.h>
 #include <linux/slab.h>
+#include <linux/edac.h>
 #include "edac_core.h"
 
 #define MODULE_NAME "pasemi_edac"
-- 
1.5.5.1

Re: linux-next: upstream build failure: pasemi_edac

[Olof Johansson]

On Wed, Apr 30, 2008 at 11:19:49AM +1000, Stephen Rothwell wrote:

> Caused by commit c3c52bce6993c6d37af2c2de9b482a7013d646a7 ("edac: fix
> module initialization on several modules 2nd time") which added a call to
> opstate_init but did not include linux/edac.h that declares it.

Grmbl. Thanks for finding it.

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 30 Apr 2008 11:16:16 +1000
> Subject: [PATCH] pasemi_edac needs to include linux/edac.h
> 
> Commit c3c52bce6993c6d37af2c2de9b482a7013d646a7 ("edac: fix module
> initialization on several modules 2nd time") added a call to opstate_init
> but did not include linux/edac.h that declares it.
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Acked-by: Olof Johansson <olof@lixom.net>