From: Arjan van de Ven <arjan@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Dave Jones <davej@redhat.com>
Subject: Re: [PATCH] Extend list debugging to cover hlists
Date: Thu, 1 May 2008 13:32:09 -0700 [thread overview]
Message-ID: <20080501133209.2c04dad0@infradead.org> (raw)
In-Reply-To: <20080502182745.GL14976@parisc-linux.org>
On Fri, 2 May 2008 12:27:46 -0600
Matthew Wilcox <matthew@wil.cx> wrote:
> +void hlist_check(struct hlist_node *n)
> +{
> + if (unlikely(*n->pprev != n)) {
> + printk(KERN_ERR "hlist corruption. *pprev should be
> %p, "
> + "but was %p\n", n, *n->pprev);
> + BUG();
> + }
> + if (unlikely(n->next != NULL && n->next->pprev != &n->next))
> {
> + printk(KERN_ERR "hlist corruption. n->next->pprev
> should be"
> + "%p, but was %p\n", &n->next,
> n->next->pprev);
> + BUG();
> + }
> +}
> +EXPORT_SYMBOL(hlist_check);
>
Hi,
I like the concept of the patch; however...
BUG() is a tad on the rude side... how about WARN_ON(1) ?
next prev parent reply other threads:[~2008-05-02 18:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 18:27 Matthew Wilcox
2008-05-01 20:32 ` Arjan van de Ven [this message]
2008-05-02 18:49 ` Matthew Wilcox
2008-05-02 19:05 ` Dave Jones
2008-05-20 3:24 ` [PATCH] Make Dave Jones
2008-05-20 14:14 ` Arjan van de Ven
2008-05-20 14:27 ` Dave Jones
2008-05-20 14:54 ` Linus Torvalds
2008-05-20 15:20 ` Dave Jones
2008-05-20 16:15 ` Arjan van de Ven
2008-05-20 15:00 ` Alexey Dobriyan
2008-05-20 15:12 ` Linus Torvalds
2008-05-20 15:22 ` Dave Jones
2008-05-20 21:52 ` [PATCH] Make (LIST_DEBUG WARN not BUG) Alexey Dobriyan
2008-05-02 23:14 ` [PATCH] Extend list debugging to cover hlists Andrew Morton
2008-05-02 23:17 ` Matthew Wilcox
2008-05-02 23:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501133209.2c04dad0@infradead.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome