From: Arjan van de Ven <arjan@infradead.org>
To: Dave Jones <davej@redhat.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make
Date: Tue, 20 May 2008 07:14:58 -0700 [thread overview]
Message-ID: <20080520071458.707d6e90@infradead.org> (raw)
In-Reply-To: <20080520032448.GA19348@redhat.com>
On Mon, 19 May 2008 23:24:48 -0400
Dave Jones <davej@redhat.com> wrote:
> printk(KERN_ERR "list_add corruption. next->prev
> should be " "prev (%p), but was %p. (next=%p).\n",
> prev, next->prev, next);
> - BUG();
> + WARN_ON(1);
> }
now that -mm has a WARN(condition, printk arguments), could we make
this use it? The advantage (apart from smaller C code) is that it puts
the printk inside the ---[ cut here ]--- which makes it more likely that
reporters (and kerneloops.org) get the actual text....
next prev parent reply other threads:[~2008-05-20 14:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 18:27 [PATCH] Extend list debugging to cover hlists Matthew Wilcox
2008-05-01 20:32 ` Arjan van de Ven
2008-05-02 18:49 ` Matthew Wilcox
2008-05-02 19:05 ` Dave Jones
2008-05-20 3:24 ` [PATCH] Make Dave Jones
2008-05-20 14:14 ` Arjan van de Ven [this message]
2008-05-20 14:27 ` Dave Jones
2008-05-20 14:54 ` Linus Torvalds
2008-05-20 15:20 ` Dave Jones
2008-05-20 16:15 ` Arjan van de Ven
2008-05-20 15:00 ` Alexey Dobriyan
2008-05-20 15:12 ` Linus Torvalds
2008-05-20 15:22 ` Dave Jones
2008-05-20 21:52 ` [PATCH] Make (LIST_DEBUG WARN not BUG) Alexey Dobriyan
2008-05-02 23:14 ` [PATCH] Extend list debugging to cover hlists Andrew Morton
2008-05-02 23:17 ` Matthew Wilcox
2008-05-02 23:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520071458.707d6e90@infradead.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®