From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: adobriyan@gmail.com, linux-kernel@vger.kernel.org,
lucho@ionkov.net, ericvh@gmail.com, mingo@elte.hu
Subject: Re: [PATCH] fix flags length in net 9p
Date: Thu, 1 May 2008 15:15:00 -0700 [thread overview]
Message-ID: <20080501151500.1afbd227.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0805011748270.12785@gandalf.stny.rr.com>
On Thu, 1 May 2008 17:50:38 -0400 (EDT)
Steven Rostedt <rostedt@goodmis.org> wrote:
>
>
>
> > + typecheck(unsigned long, flags);
ooh, I'd forgotten about typecheck.
Just use typecheck. The BUILD_BUG_ON is overkill.
> We can simply have all users of flags use the new irqflags_t type, and
> just do a one time big patch (grant you, that would break all pending
> patches before that). But we can also write up a script that can convert
> patches as well.
y:/usr/src/linux-2.6.25> grep -rl 'unsigned long flags' . | wc -l
2311
eargh. I agree with me.
next prev parent reply other threads:[~2008-05-01 22:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 21:08 Steven Rostedt
2008-05-01 21:19 ` Andrew Morton
2008-05-01 21:25 ` Steven Rostedt
2008-05-01 21:26 ` Daniel Walker
2008-05-01 21:38 ` Steven Rostedt
2008-05-01 21:41 ` Adrian Bunk
2008-05-01 22:01 ` Daniel Walker
2008-05-01 22:07 ` Andrew Morton
2008-05-01 22:32 ` Alexey Dobriyan
2008-05-01 21:46 ` Steven Rostedt
2008-05-01 22:29 ` Alexey Dobriyan
2008-05-01 21:50 ` Steven Rostedt
2008-05-01 22:15 ` Andrew Morton [this message]
2008-05-01 22:03 ` Christoph Hellwig
2008-05-02 11:39 ` Enrico Weigelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501151500.1afbd227.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome