From: Enrico Weigelt <weigelt@metux.de>
To: linux kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix flags length in net 9p
Date: Fri, 2 May 2008 13:39:23 +0200 [thread overview]
Message-ID: <20080502113923.GA7997@nibiru.local> (raw)
In-Reply-To: <Pine.LNX.4.58.0805011706070.12785@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Some files in the net/9p directory uses "int" for flags. This can
> cause hard to find bugs on some architectures. This patch converts the
> flags to use "long" instead.
IMHO it would be more consequent and clean to introduce an separate
type for this and only use specific macros for manipulation. Of course
this introduced some typing overhead, but enforces the coder to think
more carefully about his code. For critical things like kernel stuff,
I really prefer this way.
BTW: I just wondered a bit how the 9p driver finds out the numeric
user ID's for 9P user names.
cu
--
---------------------------------------------------------------------
Enrico Weigelt == metux IT service - http://www.metux.de/
---------------------------------------------------------------------
Please visit the OpenSource QM Taskforce:
http://wiki.metux.de/public/OpenSource_QM_Taskforce
Patches / Fixes for a lot dozens of packages in dozens of versions:
http://patches.metux.de/
---------------------------------------------------------------------
prev parent reply other threads:[~2008-05-02 11:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 21:08 Steven Rostedt
2008-05-01 21:19 ` Andrew Morton
2008-05-01 21:25 ` Steven Rostedt
2008-05-01 21:26 ` Daniel Walker
2008-05-01 21:38 ` Steven Rostedt
2008-05-01 21:41 ` Adrian Bunk
2008-05-01 22:01 ` Daniel Walker
2008-05-01 22:07 ` Andrew Morton
2008-05-01 22:32 ` Alexey Dobriyan
2008-05-01 21:46 ` Steven Rostedt
2008-05-01 22:29 ` Alexey Dobriyan
2008-05-01 21:50 ` Steven Rostedt
2008-05-01 22:15 ` Andrew Morton
2008-05-01 22:03 ` Christoph Hellwig
2008-05-02 11:39 ` Enrico Weigelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080502113923.GA7997@nibiru.local \
--to=weigelt@metux.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome