From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: kosaki.motohiro@jp.fujitsu.com, Li Zefan <lizf@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] mm/page_alloc.c: fix a typo
Date: Thu, 08 May 2008 09:08:00 +0900 [thread overview]
Message-ID: <20080508090647.4A7B.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0805061050110.23336@schroedinger.engr.sgi.com>
> > Sorry for the noise, but the signed-off was eaten. :(
> > Maybe I should leave a blank line before the signed-off.
>
> I think the | there was some developers attempt to avoid gcc generating
> too many branches. I am fine either way.
Agreed.
but it is not normal conding style.
comment adding is better, IMHO.
at first, I think typo too.
next prev parent reply other threads:[~2008-05-08 0:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 9:38 Li Zefan
2008-05-06 9:41 ` Li Zefan
2008-05-06 9:50 ` Li Zefan
2008-05-06 14:19 ` Andrew Morton
2008-05-07 1:27 ` Li Zefan
2008-05-07 4:32 ` Li Zefan
2008-05-06 17:51 ` Christoph Lameter
2008-05-08 0:08 ` KOSAKI Motohiro [this message]
2008-05-06 18:18 ` Oliver Pinter
2008-05-06 18:26 ` Christoph Lameter
2008-05-06 18:28 ` Oliver Pinter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508090647.4A7B.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®