From: Ingo Molnar <mingo@elte.hu>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: [patch] drivers/media/video build fix for certain modular builds
Date: Fri, 16 May 2008 09:10:29 +0200 [thread overview]
Message-ID: <20080516071029.GA13147@elte.hu> (raw)
testing of the -tip tree found the following missing symbols build bug:
LD init/built-in.o
LD .tmp_vmlinux1
drivers/built-in.o: In function `vidioc_g_ctrl':
radio-maxiradio.c:(.text+0xd3337): undefined reference to `video_devdata'
drivers/built-in.o: In function `vidioc_g_frequency':
radio-maxiradio.c:(.text+0xd3368): undefined reference to `video_devdata'
drivers/built-in.o: In function `vidioc_s_ctrl':
[...]
which happens if certain media drivers are modular:
http://redhat.com/~mingo/misc/config-Thu_May_15_18_10_27_CEST_2008.bad
the problem is:
CONFIG_VIDEO_MEDIA=m
CONFIG_VIDEO_DEV=y
CONFIG_RADIO_MAXIRADIO=y
CONFIG_VIDEO_V4L2=y
Connecting the build dependencies tree from drivers/media/ to
drivers/media/video/ allows the built-in drivers(s) to pick up the
CONFIG_VIDEO_DEV=y symbols.
---
drivers/media/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/media/Makefile
===================================================================
--- linux.orig/drivers/media/Makefile
+++ linux/drivers/media/Makefile
@@ -2,7 +2,7 @@
# Makefile for the kernel multimedia device drivers.
#
-obj-y := common/
+obj-y := common/ video/
obj-$(CONFIG_VIDEO_MEDIA) += common/
next reply other threads:[~2008-05-16 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 7:10 Ingo Molnar [this message]
2008-05-16 9:24 ` Sam Ravnborg
2008-05-16 11:19 ` Ingo Molnar
2008-05-20 8:02 ` [patch] dvb/usb: input layer dependency fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080516071029.GA13147@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®