mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	Michael Krufky <mkrufky@linuxtv.org>,
	Patrick Boettcher <pb@linuxtv.org>
Subject: [patch] dvb/usb: input layer dependency fixes
Date: Tue, 20 May 2008 10:02:33 +0200	[thread overview]
Message-ID: <20080520080233.GA1668@elte.hu> (raw)
In-Reply-To: <20080516071029.GA13147@elte.hu>


testing of the -tip tree found the following build failures on 
2.6.26-rc3:

  drivers/built-in.o: In function `ttusb_dec_disconnect':
  ttusb_dec.c:(.text+0xa2c95): undefined reference to `input_unregister_device'

  drivers/built-in.o: In function `dvb_usb_read_remote_control':
  dvb-usb-remote.c:(.text+0xa6a94): undefined reference to `input_event'

with this config:

  http://redhat.com/~mingo/misc/config-Tue_May_20_03_48_57_CEST_2008.bad

these are due to the media/dvb/usb layer having dependencies on INPUT 
functionality, without having that spelled out in the Kconfig file.

this patch makes that dependency explicit (for the drivers affected), 
which solves the build error.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/media/dvb/dvb-usb/Kconfig   |    2 +-
 drivers/media/dvb/ttusb-dec/Kconfig |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Index: linux/drivers/media/dvb/dvb-usb/Kconfig
===================================================================
--- linux.orig/drivers/media/dvb/dvb-usb/Kconfig
+++ linux/drivers/media/dvb/dvb-usb/Kconfig
@@ -1,6 +1,6 @@
 config DVB_USB
 	tristate "Support for various USB DVB devices"
-	depends on DVB_CORE && USB && I2C
+	depends on DVB_CORE && USB && I2C && INPUT
 	depends on HOTPLUG	# due to FW_LOADER
 	select FW_LOADER
 	help
Index: linux/drivers/media/dvb/ttusb-dec/Kconfig
===================================================================
--- linux.orig/drivers/media/dvb/ttusb-dec/Kconfig
+++ linux/drivers/media/dvb/ttusb-dec/Kconfig
@@ -1,6 +1,6 @@
 config DVB_TTUSB_DEC
 	tristate "Technotrend/Hauppauge USB DEC devices"
-	depends on DVB_CORE && USB
+	depends on DVB_CORE && USB && INPUT
 	depends on HOTPLUG	# due to FW_LOADER
 	select FW_LOADER
 	select CRC32

      parent reply	other threads:[~2008-05-20  8:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-16  7:10 [patch] drivers/media/video build fix for certain modular builds Ingo Molnar
2008-05-16  9:24 ` Sam Ravnborg
2008-05-16 11:19   ` Ingo Molnar
2008-05-20  8:02 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080520080233.GA1668@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mkrufky@linuxtv.org \
    --cc=pb@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®