* [PATCH] x86: fix crash on cpu hotplug on pat-incapable machines
@ 2008-05-14 9:20 Avi Kivity
2008-05-16 11:14 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Avi Kivity @ 2008-05-14 9:20 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel
pat_disable() is __init, which means it goes away after booting is complete.
Unfortunately it is used by the hotplug code if the machine is not
pat-capable, causing a crash.
Fix by marking pat_disable() as __cpuinit.
Signed-off-by: Avi Kivity <avi@qumranet.com>
---
arch/x86/mm/pat.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index 60adbe2..5a969c9 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -28,7 +28,7 @@
#ifdef CONFIG_X86_PAT
int __read_mostly pat_wc_enabled = 1;
-void __init pat_disable(char *reason)
+void __cpuinit pat_disable(char *reason)
{
pat_wc_enabled = 0;
printk(KERN_INFO "%s\n", reason);
--
1.5.5.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: fix crash on cpu hotplug on pat-incapable machines
2008-05-14 9:20 [PATCH] x86: fix crash on cpu hotplug on pat-incapable machines Avi Kivity
@ 2008-05-16 11:14 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-05-16 11:14 UTC (permalink / raw)
To: Avi Kivity; +Cc: linux-kernel, Thomas Gleixner, H. Peter Anvin
* Avi Kivity <avi@qumranet.com> wrote:
> pat_disable() is __init, which means it goes away after booting is
> complete. Unfortunately it is used by the hotplug code if the machine
> is not pat-capable, causing a crash.
>
> Fix by marking pat_disable() as __cpuinit.
applied, thanks Avi.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-16 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-14 9:20 [PATCH] x86: fix crash on cpu hotplug on pat-incapable machines Avi Kivity
2008-05-16 11:14 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®