From: Miklos Szeredi <miklos@szeredi.hu>
To: akpm@linux-foundation.org
Cc: hch@infradead.org, viro@ZenIV.linux.org.uk, ezk@cs.sunysb.edu,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [patch 09/22] vfs: truncate: dont check immutable twice
Date: Fri, 16 May 2008 18:31:45 +0200 [thread overview]
Message-ID: <20080516163226.007338262@szeredi.hu> (raw)
In-Reply-To: <20080516163136.560107038@szeredi.hu>
[-- Attachment #1: truncate_immutable_cleanup.patch --]
[-- Type: text/plain, Size: 739 bytes --]
From: Miklos Szeredi <mszeredi@suse.cz>
vfs_permission(MAY_WRITE) already checked for the inode being
immutable, so no need to repeat it.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
---
fs/open.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/fs/open.c
===================================================================
--- linux-2.6.orig/fs/open.c 2008-05-16 17:50:45.000000000 +0200
+++ linux-2.6/fs/open.c 2008-05-16 17:50:46.000000000 +0200
@@ -254,7 +254,7 @@ static long do_sys_truncate(const char _
goto mnt_drop_write_and_out;
error = -EPERM;
- if (IS_IMMUTABLE(inode) || IS_APPEND(inode))
+ if (IS_APPEND(inode))
goto mnt_drop_write_and_out;
error = get_write_access(inode);
--
next prev parent reply other threads:[~2008-05-16 16:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 16:31 [patch 00/22] vfs: fixes and cleanups (v3) Miklos Szeredi
2008-05-16 16:31 ` [patch 01/22] nfsd: clean up mnt_want_write calls Miklos Szeredi
2008-05-16 16:31 ` [patch 02/22] cgroup: dont call vfs_mkdir Miklos Szeredi
2008-05-16 16:31 ` [patch 03/22] reiserfs: dont call vfs_rmdir Miklos Szeredi
2008-05-16 16:31 ` [patch 04/22] reiserfs: dont call notify_change Miklos Szeredi
2008-05-16 16:31 ` [patch 05/22] sysfs: " Miklos Szeredi
2008-05-16 16:31 ` [patch 06/22] hpfs: " Miklos Szeredi
2008-05-16 16:31 ` [patch 07/22] fat: " Miklos Szeredi
2008-05-16 23:25 ` OGAWA Hirofumi
2008-05-17 6:56 ` Miklos Szeredi
2008-05-17 13:01 ` Brad Boyer
2008-05-19 7:47 ` Miklos Szeredi
2008-05-16 16:31 ` [patch 08/22] vfs: immutable inode checking cleanup Miklos Szeredi
2008-05-16 16:31 ` Miklos Szeredi [this message]
2008-05-16 16:31 ` [patch 10/22] vfs: create file_truncate() helper Miklos Szeredi
2008-05-16 16:31 ` [patch 11/22] vfs: utimes immutable fix Miklos Szeredi
2008-05-16 16:31 ` [patch 12/22] vfs: utimes cleanup Miklos Szeredi
2008-05-16 16:31 ` [patch 13/22] vfs: add path_create() and path_mknod() Miklos Szeredi
2008-05-16 16:31 ` [patch 14/22] vfs: add path_mkdir() Miklos Szeredi
2008-05-16 16:31 ` [patch 15/22] vfs: add path_rmdir() Miklos Szeredi
2008-05-16 16:31 ` [patch 16/22] vfs: add path_unlink() Miklos Szeredi
2008-05-16 16:31 ` [patch 17/22] vfs: add path_symlink() Miklos Szeredi
2008-05-17 1:14 ` Tetsuo Handa
2008-05-17 7:36 ` Miklos Szeredi
2008-05-16 16:31 ` [patch 18/22] vfs: add path_link() Miklos Szeredi
2008-05-16 16:31 ` [patch 19/22] vfs: add path_rename() Miklos Szeredi
2008-05-16 16:31 ` [patch 20/22] vfs: add path_setattr() Miklos Szeredi
2008-05-16 16:31 ` [patch 21/22] vfs: add path_setxattr() Miklos Szeredi
2008-05-16 16:31 ` [patch 22/22] vfs: add path_removexattr() Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080516163226.007338262@szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@linux-foundation.org \
--cc=ezk@cs.sunysb.edu \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®