mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, hch@infradead.org,
	viro@ZenIV.linux.org.uk, ezk@cs.sunysb.edu,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 07/22] fat: dont call notify_change
Date: Sat, 17 May 2008 08:25:15 +0900	[thread overview]
Message-ID: <87prrl7rxg.fsf@duaron.myhome.or.jp> (raw)
In-Reply-To: <20080516163222.235825996@szeredi.hu> (Miklos Szeredi's message of "Fri, 16 May 2008 18:31:43 +0200")

Miklos Szeredi <miklos@szeredi.hu> writes:

> From: Miklos Szeredi <mszeredi@suse.cz>
>
> The FAT_IOCTL_SET_ATTRIBUTES ioctl() calls notify_change() to change
> the file mode before changing the inode attributes.  Replace with
> explicit calls to security_inode_setattr(), fat_setattr() and
> fsnotify_change().
>
> This is equivalent to the original.  The reason it is needed, is that
> later in the series we move the immutable check into notify_change().
> That would break the FAT_IOCTL_SET_ATTRIBUTES ioctl, as it needs to
> perform the mode change regardless of the immutability of the file.
>
> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
> CC: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Don't we need to add EXPORT_SYMBOL(security_inode_setattr)? Otherwise,
looks good to me.

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2008-05-16 23:25 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-16 16:31 [patch 00/22] vfs: fixes and cleanups (v3) Miklos Szeredi
2008-05-16 16:31 ` [patch 01/22] nfsd: clean up mnt_want_write calls Miklos Szeredi
2008-05-16 16:31 ` [patch 02/22] cgroup: dont call vfs_mkdir Miklos Szeredi
2008-05-16 16:31 ` [patch 03/22] reiserfs: dont call vfs_rmdir Miklos Szeredi
2008-05-16 16:31 ` [patch 04/22] reiserfs: dont call notify_change Miklos Szeredi
2008-05-16 16:31 ` [patch 05/22] sysfs: " Miklos Szeredi
2008-05-16 16:31 ` [patch 06/22] hpfs: " Miklos Szeredi
2008-05-16 16:31 ` [patch 07/22] fat: " Miklos Szeredi
2008-05-16 23:25   ` OGAWA Hirofumi [this message]
2008-05-17  6:56     ` Miklos Szeredi
2008-05-17 13:01       ` Brad Boyer
2008-05-19  7:47         ` Miklos Szeredi
2008-05-16 16:31 ` [patch 08/22] vfs: immutable inode checking cleanup Miklos Szeredi
2008-05-16 16:31 ` [patch 09/22] vfs: truncate: dont check immutable twice Miklos Szeredi
2008-05-16 16:31 ` [patch 10/22] vfs: create file_truncate() helper Miklos Szeredi
2008-05-16 16:31 ` [patch 11/22] vfs: utimes immutable fix Miklos Szeredi
2008-05-16 16:31 ` [patch 12/22] vfs: utimes cleanup Miklos Szeredi
2008-05-16 16:31 ` [patch 13/22] vfs: add path_create() and path_mknod() Miklos Szeredi
2008-05-16 16:31 ` [patch 14/22] vfs: add path_mkdir() Miklos Szeredi
2008-05-16 16:31 ` [patch 15/22] vfs: add path_rmdir() Miklos Szeredi
2008-05-16 16:31 ` [patch 16/22] vfs: add path_unlink() Miklos Szeredi
2008-05-16 16:31 ` [patch 17/22] vfs: add path_symlink() Miklos Szeredi
2008-05-17  1:14   ` Tetsuo Handa
2008-05-17  7:36     ` Miklos Szeredi
2008-05-16 16:31 ` [patch 18/22] vfs: add path_link() Miklos Szeredi
2008-05-16 16:31 ` [patch 19/22] vfs: add path_rename() Miklos Szeredi
2008-05-16 16:31 ` [patch 20/22] vfs: add path_setattr() Miklos Szeredi
2008-05-16 16:31 ` [patch 21/22] vfs: add path_setxattr() Miklos Szeredi
2008-05-16 16:31 ` [patch 22/22] vfs: add path_removexattr() Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87prrl7rxg.fsf@duaron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@linux-foundation.org \
    --cc=ezk@cs.sunysb.edu \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®