* Re: [PATCH 1/4] lmb: Fix compile warning [not found] ` <1211136296-4572-2-git-send-email-galak@kernel.crashing.org> @ 2008-05-19 3:31 ` David Miller 2008-05-19 4:34 ` [PATCH v2] " Kumar Gala 0 siblings, 1 reply; 3+ messages in thread From: David Miller @ 2008-05-19 3:31 UTC (permalink / raw) To: galak; +Cc: paulus, linuxppc-dev, linux-kernel From: Kumar Gala <galak@kernel.crashing.org> Date: Sun, 18 May 2008 13:44:53 -0500 > lib/lmb.c: In function 'lmb_dump_all': > lib/lmb.c:51: warning: format '%lx' expects type 'long unsigned int', but argument 2 has type 'u64' > > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> That's not right either. We'll need to cast this argument because it's a different type on sparc vs sparc64 vs powerpc. u64 != unsigned long long ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] lmb: Fix compile warning 2008-05-19 3:31 ` [PATCH 1/4] lmb: Fix compile warning David Miller @ 2008-05-19 4:34 ` Kumar Gala 2008-05-19 5:09 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: Kumar Gala @ 2008-05-19 4:34 UTC (permalink / raw) To: David Miller; +Cc: paulus, linuxppc-dev, linux-kernel lib/lmb.c: In function 'lmb_dump_all': lib/lmb.c:51: warning: format '%lx' expects type 'long unsigned int', but argument 2 has type 'u64' Signed-off-by: Kumar Gala <galak@kernel.crashing.org> --- Cast so it works everywhere. - k lib/lmb.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/lmb.c b/lib/lmb.c index 867f7b5..5d7b928 100644 --- a/lib/lmb.c +++ b/lib/lmb.c @@ -48,7 +48,8 @@ void lmb_dump_all(void) } pr_info(" reserved.cnt = 0x%lx\n", lmb.reserved.cnt); - pr_info(" reserved.size = 0x%lx\n", lmb.reserved.size); + pr_info(" reserved.size = 0x%llx\n", + (unsigned long long)lmb.memory.size); for (i=0; i < lmb.reserved.cnt ;i++) { pr_info(" reserved.region[0x%lx].base = 0x%llx\n", i, (unsigned long long)lmb.reserved.region[i].base); -- 1.5.4.5 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] lmb: Fix compile warning 2008-05-19 4:34 ` [PATCH v2] " Kumar Gala @ 2008-05-19 5:09 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2008-05-19 5:09 UTC (permalink / raw) To: galak; +Cc: linuxppc-dev, paulus, linux-kernel From: Kumar Gala <galak@kernel.crashing.org> Date: Sun, 18 May 2008 23:34:36 -0500 (CDT) > lib/lmb.c: In function 'lmb_dump_all': > lib/lmb.c:51: warning: format '%lx' expects type 'long unsigned int', but argument 2 has type 'u64' > > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> Acked-by: David S. Miller <davem@davemloft.net> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-19 5:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1211136296-4572-1-git-send-email-galak@kernel.crashing.org>
[not found] ` <1211136296-4572-2-git-send-email-galak@kernel.crashing.org>
2008-05-19 3:31 ` [PATCH 1/4] lmb: Fix compile warning David Miller
2008-05-19 4:34 ` [PATCH v2] " Kumar Gala
2008-05-19 5:09 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®