mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* PATCH] Replace a printk + WARN_ON() to a WARN()
@ 2008-05-20  3:41 Arjan van de Ven
  0 siblings, 0 replies; only message in thread
From: Arjan van de Ven @ 2008-05-20  3:41 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel


From: Arjan van de Ven <arjan@linux.intel.com>
Subject: [PATCH] Replace a printk + WARN_ON() to a WARN()

Replace a printk+WARN_ON() by a WARN(); this increases the
chance of the string making it into the bugreport
(eg it goes inside the ---[ cute here ]--- section)

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
 kernel/irq/manage.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 46d6611..e296f67 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -224,9 +224,7 @@ int set_irq_wake(unsigned int irq, unsigned int on)
 			set_wake = NULL;
 	} else {
 		if (desc->wake_depth == 0) {
-			printk(KERN_WARNING "Unbalanced IRQ %d "
-					"wake disable\n", irq);
-			WARN_ON(1);
+			WARN(1, "Unbalanced IRQ %d wake disable\n", irq);
 		} else if (--desc->wake_depth == 0)
 			desc->status &= ~IRQ_WAKEUP;
 		else
-- 
1.5.4.5


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-05-20 13:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-20  3:41 PATCH] Replace a printk + WARN_ON() to a WARN() Arjan van de Ven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®