mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Mike Frysinger" <vapier.adi@gmail.com>
Cc: cooloney@kernel.org, linux-kernel@vger.kernel.org,
	michael.hennerich@analog.com
Subject: Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-try-2.patch added to -mm tree
Date: Wed, 21 May 2008 16:11:37 -0700	[thread overview]
Message-ID: <20080521161137.ed4bd6cf.akpm@linux-foundation.org> (raw)
In-Reply-To: <8bd0f97a0805201741h13e44c4dkead97118d7d137e8@mail.gmail.com>

On Tue, 20 May 2008 20:41:13 -0400
"Mike Frysinger" <vapier.adi@gmail.com> wrote:

> > This:
> >
> >> -#if defined(__arm__) || defined(__mips__) || defined(__avr32__)
> >> +#if defined(__arm__) || defined(__mips__) || defined(__avr32__) || defined(bfin)
> >
> > should probably be using CONFIG_foo but that might not work if it's to
> > be preprocessed by userspace.  I didn't look.  Plus that'd be
> > off-topic.
> 
> it should be defined(__bfin__) at least.

Well I made that change, but this all has a rather untested feeling to
it.


  reply	other threads:[~2008-05-21 23:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200805200608.m4K68d0N008092@imap1.linux-foundation.org>
2008-05-20  7:51 ` Bryan Wu
2008-05-20  8:02   ` Andrew Morton
2008-05-21  0:41     ` Mike Frysinger
2008-05-21 23:11       ` Andrew Morton [this message]
2008-05-21 23:23         ` Mike Frysinger
2008-05-21 23:34   ` Mike Frysinger
2008-05-27 11:15     ` Hennerich, Michael
2008-05-27 15:49       ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521161137.ed4bd6cf.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=cooloney@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®