From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Bryan Wu" <cooloney@kernel.org>,
linux-kernel@vger.kernel.org, michael.hennerich@analog.com
Subject: Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-try-2.patch added to -mm tree
Date: Tue, 20 May 2008 20:41:13 -0400 [thread overview]
Message-ID: <8bd0f97a0805201741h13e44c4dkead97118d7d137e8@mail.gmail.com> (raw)
In-Reply-To: <20080520010223.5e55d074.akpm@linux-foundation.org>
On Tue, May 20, 2008 at 4:02 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Tue, 20 May 2008 15:51:13 +0800 "Bryan Wu" <cooloney@kernel.org> wrote:
>> Need I resend out the a new patch which fold these 3 patches together.
>> it is easier for you to maintain.
>
> Nope, I keep the patches separate and then fold them prior to sending
> to Linus.
>
> I marked this as for-2.6.26 as it's clearly non-injurious to existing stuff.
>
> This:
>
>> -#if defined(__arm__) || defined(__mips__) || defined(__avr32__)
>> +#if defined(__arm__) || defined(__mips__) || defined(__avr32__) || defined(bfin)
>
> should probably be using CONFIG_foo but that might not work if it's to
> be preprocessed by userspace. I didn't look. Plus that'd be
> off-topic.
it should be defined(__bfin__) at least. perhaps i should add that
check to checkpatch.pl as well ...
-mike
next prev parent reply other threads:[~2008-05-21 0:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200805200608.m4K68d0N008092@imap1.linux-foundation.org>
2008-05-20 7:51 ` Bryan Wu
2008-05-20 8:02 ` Andrew Morton
2008-05-21 0:41 ` Mike Frysinger [this message]
2008-05-21 23:11 ` Andrew Morton
2008-05-21 23:23 ` Mike Frysinger
2008-05-21 23:34 ` Mike Frysinger
2008-05-27 11:15 ` Hennerich, Michael
2008-05-27 15:49 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0805201741h13e44c4dkead97118d7d137e8@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®